86270 - implement default templates using code

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

we should implement default templates using code instead of inserting them into 
the xsl document. There is two advantages with this:

1. All default templates can't be implemented by inserting nodes in the xslt-dom
2. We don't have to modify the xslt document given to us

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: ver 1

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: ver 1 -w

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The patch basically does two things. It removes the code that adds the default 
templates to the xslt document, and it adds an extra |else 
processDefaultTemplate(...);| to each |if(xslTemplate) processTemplate(...);|

Comment 4

[Peter Van der Beken [:peterv]]

I like it, but we now have this every time:

if (xslTemplate)
    processTemplate(node, xslTemplate, ps);
else
    processDefaultTemplate(node, ps, mode);

Do you think we could put the NULL check and processDefaultTemplate inside
processTemplate? So that we (I?) don't forget adding the processDefaultTemplate
after every processTemplate. Then again, it might be too much trouble for the
few cases. 

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I originally did it that way (see attachment 34255 [details] [diff] [review]), but I wasn't quite happy 
with it. First of all I had to send |mode| to processTemplate which would only 
be used by the default-template code. Second, there is code that calls 
processTemplate but _should't_ invoke default templates (the code for xsl:call-
template).

So, could I convince you to the current flow?

Comment 6

[Peter Van der Beken [:peterv]]

r=peterv.

Comment 7

[Johnny Stenback (:jst)]

sr=jst

Comment 8

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in

Comment 10

[Axel Hecht]

bitching buttons, verfication spam