Closed Bug 862756 Opened 11 years ago Closed 11 years ago

Scrolling the contacts lists should be near 50fps

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, b2g18 verified, b2g18-v1.0.1 verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
b2g18 --- verified
b2g18-v1.0.1 --- verified

People

(Reporter: alberto.pastor, Assigned: alberto.pastor)

Details

Attachments

(2 files)

Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9260
355 bytes, text/html
crdlc
: review+
Details
test result
227.40 KB, image/png
Details 
Avoiding paint the contacts that are not in the viewport will improve performance on scrolling
Assignee: nobody → alberto.pastor
Pointer to Github pull-request
Attachment #738926 - Flags: review?(crdlc)
There is only one comment on Github, I gonna try to test it on my device, thanks Alberto
Status: NEW → ASSIGNED
Nominating to leo due to people from LG said to us that we should increase fps in the scroll
blocking-b2g: --- → leo?
I emailed [vendor] guys for commenting here with the results of their tests
Comment on attachment 738926 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9260

Great work, thanks
Attachment #738926 - Flags: review?(crdlc) → review+
Attached image test result — 

    
    

    
  
Alberto ask me to comment here. 
So, I just simply attached a image file which presents the test result.
When I checked the dragging performance on contacts application with these two patches

1. Removed MouseEventShim Library
2. Forcing show hidden letters when no scrolling

the performance was improved, adbout 9fps higher than before.
pls, see the attachment.  
thanks

    
    

    
  
Marking confidential at partner request.
Group: mozilla-corporation-confidential

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/c477c09bd11b5805bad29a3cb910ded03c0ed433
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: leo? → tef+
Group: mozilla-corporation-confidential

    
    

    
  
Hi Sheriffs, 
inclding [NO_UPLIFT] whiteboard because Alberto will do the uplift by himself
Whiteboard: [NO_UPLIFT]

    
    

    
  
v1-train: 3db11135ee8742cb38b7632044ad1e768c647ff0
v1.0.1: a20c344972508ceba66d98319f5535d734bdd051

          status-b2g18:
          affected → fixed

          status-b2g18-v1.0.1:
          affected → fixed
Whiteboard: [NO_UPLIFT]

    
    

    
  
The issue seems to be fixed. Able to scroll the contacts lists around 50 frames per second.

Tested on Leo and Inari device

Leo Build ID: 20130426070204
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441
Gaia: c9046a7acef33328977840176ff5574720d2c74c

Inari Build ID: 20130430070201
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7
Gaia: de0f1fc6c58616b8a33fca482f1f8684d4e74e9e
Status: RESOLVED → VERIFIED

          status-b2g18:
          fixed → verified

          status-b2g18-v1.0.1:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: