[MakeAPI] Use GET for Search endpoint

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: cade, Assigned: cade)

Tracking

Details

(Whiteboard: [MakeAPI])

Attachments

(1 attachment, 1 obsolete attachment)

42 bytes, text/x-github-pull-request
mjschranz
: review+
Details | Review | Splinter Review
(Assignee)

Description

6 years ago
Currently it's using POST to hit the search API, but it should be GET.
(Assignee)

Updated

6 years ago
Assignee: nobody → chris
(Assignee)

Comment 1

6 years ago
Created attachment 739218 [details] [review]
Fix Routes, make Search use GET

https://github.com/mozilla/MakeAPI/pull/13
Attachment #739218 - Flags: review?(schranz.m)
Comment on attachment 739218 [details] [review]
Fix Routes, make Search use GET

R+ from me.
Attachment #739218 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 3

6 years ago
Merged: https://github.com/mozilla/MakeAPI/commit/dc799dad16419b6e83ac0bc39129e5d08cf34ef2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

6 years ago
Gotta fix this to use QueryStrings.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

6 years ago
Created attachment 739651 [details] [review]
https://github.com/mozilla/MakeAPI/pull/18

This patch makes the Client library convert the search object into a string, then URL encode it. it's then converted back into a JSON Object on the server.
Attachment #739218 - Attachment is obsolete: true
Attachment #739651 - Flags: review?(schranz.m)
Comment on attachment 739651 [details] [review]
https://github.com/mozilla/MakeAPI/pull/18

As noted in IRC, there seem to be issues with doing search and also applying a sortByField.
Attachment #739651 - Flags: review?(schranz.m) → review-
(Assignee)

Comment 7

6 years ago
Comment on attachment 739651 [details] [review]
https://github.com/mozilla/MakeAPI/pull/18

The issues with sorting are present without this patch. file a new bug for it plz.
Attachment #739651 - Flags: review- → review?
(Assignee)

Updated

6 years ago
Attachment #739651 - Flags: review? → review?(schranz.m)
Comment on attachment 739651 [details] [review]
https://github.com/mozilla/MakeAPI/pull/18

Land this, but don't close the bug until I file a new bug on the mentioned issue.
Attachment #739651 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 9

6 years ago
Merged: https://github.com/mozilla/MakeAPI/commit/409c6e98b98804006ac873230501ea6885fb9ade

close once that ticket is filed.
Flags: needinfo?(schranz.m)
Filed bug 864353.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Flags: needinfo?(schranz.m)
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.