862849 - remove __iterator__ use from the devtools

Status: RESOLVED FIXED

(DevTools :: Object Inspector, defect)

Description

[Brandon Benvie [:benvie]]

All of these set their `__iterator__` property. The iterator protocol has been changed so that for-of looks for the `iterator` property.

Comment 1

[Brandon Benvie [:benvie]]

So upon further inspection, this was partially my error. I didn't realize `__iterator__` worked with for-in, versus `iterator` which works with for-of. However, we should still eventually upgrade all the iterators to use for-of anyway so this bug still stands.

Comment 2

[Brandon Benvie [:benvie]]

Attachment: WIP1

Comment 3

[Brandon Benvie [:benvie]]

Attachment: bug-862849.patch

Depends on delegating yield to non-generator iterators which has landed on mozilla-inbound but hasn't propagated to fx-team yet. Should be good to go tomorrow. Here's a try that uses a slightly modified version that doesn't use delegating yield: https://tbpl.mozilla.org/?tree=Try&rev=a7702e9d5e33

Comment 4

[Brandon Benvie [:benvie]]

Attachment: bug-862849.patch

Fixes the webconsole failures. Also switches to legacy generators since apparently ES6 ones are being disabled for now (bug 918083). They're still better than using __iterator__ though, since you only have to make slight changes to the generator function itself in order to update to the new version, rather than find all the places where "in" needs to be changed to "of" (as I did in this patch).

https://tbpl.mozilla.org/?tree=Try&rev=fcc88c0bc646

Comment 5

[Brandon Benvie [:benvie]]

https://hg.mozilla.org/integration/fx-team/rev/69ebfb936442

Comment 6

[Nick Alexander :nalexander [he/him]]

Backed out for bc orange:

https://hg.mozilla.org/integration/fx-team/rev/1bab2224b51a

Comment 7

[Brandon Benvie [:benvie]]

I think I'll need to wait until 28 for this to land. The problem is that bug 918083 will remove handling for ES6 generators in 27, but hasn't landed yet. However, the updated iteration protocol is still being used which is only compatible with new generators. TLDR the version of this patch with ES6 generators can land when we switch to 28, so I'll just hold off until then.

Comment 8

[Brandon Benvie [:benvie]]

https://hg.mozilla.org/integration/fx-team/rev/7dd13d06f132

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/2c3cd0a21ca0 for breaking a bunch of webconsole tests: https://tbpl.mozilla.org/php/getParsedLog.php?id=30233332&tree=Fx-Team

Comment 10

[Brandon Benvie [:benvie]]

https://tbpl.mozilla.org/?tree=Try&rev=dc3e5cc8b0e6

Comment 11

[Brandon Benvie [:benvie]]

https://hg.mozilla.org/integration/fx-team/rev/8cc5f8a66d80

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8cc5f8a66d80