862921 - ParallelArray.js: Generalize AssertSequentialIsOK logic and improve its error message.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

1. If one passes a `mode` argument without a property named `mode`,
       the previous version will fall into the ThrowError branch
       (because mode.mode => undefined and undefined !== "seq")
    
    2. The old error message used the strings "par" and "seq", which might
       make the reader think that the assertion is solely about the
       appropriate value for the `mode` property, which happens to take on
       the values "par" or "seq" in some cases.  But the real condition
       being signalled here is not about the string values "par" or "seq";
       it is instead about the dynamic behavior of the runtime system.
       This changes the error message to use longer phrases, which should
       hopefully make the intent clearer.
    
    There is a third change I want to make, changing the logic of the
    conditional guard further, but that change is not as important to me
    as the two above.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch A v1: fix the guard and the message.

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 738587 [details] [diff] [review]
patch A v1: fix the guard and the message.

(removing review request until I resolve why this is not rendering in splinter.)

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch A v1: fix the guard and the message.

(this is the same as 738587 except generated without `--color` flag.)

Comment 4

[Felix S. Klock II [:pnkfelix, :fklock]]

try build: https://tbpl.mozilla.org/?tree=Try&rev=76f24049efc3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a391f846c42

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a391f846c42