862927 - Marionette can tap a read-only image in contacts.

Status: RESOLVED WORKSFORME

(Remote Protocol :: Marionette, defect)

Description

[Roy Collings]

Attachment: Image of the contact with the icon beside the image greyed out. In this state the image cannot be manually tapped.

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.63 Safari/537.31

Steps to reproduce:

When editing a contact that has an image, click the little red icon beside the image -> It changes to a grey icon -> tap the image with marionette.

the code for this (once you are editing the contact) is:

        #
        # Tap the little red icon beside the image ...
        #
        x = self.marionette.find_element("xpath", 
                                         ".//*[@id='thumbnail-action']//button[@id='img-delete-button']")
        self.marionette.tap(x)
        
        #
        # Tap the image itself ...
        #
        x=self.marionette.find_element("id", "thumbnail-photo")
        self.marionette.tap(x)


Actual results:

The option to edit the image from the gallery or the camera is displayed.


Expected results:

Nothing. This image is now read-only (it cannot be tapped manually while the little icon beside it is gray).

Comment 1

[Roy Collings]

Possibly connected: marionette "is_enabled()" returns true for this element while it's actually disabled.
However, it also incorrectly returns true for several other disabled elements on this screen, but correctly doesn't tap (or click()) them while they're in this state.

For example (from the Contacts -> view contact -> Edit contact screen):

        # Put the phone number into 'reset' mode (disables the "number_0" field) ... 
        x = self.marionette.find_element("xpath", ".//*[@id='add-phone-0']//button[@id='img-delete-button']")
        self.marionette.tap(x)
         
        time.sleep(2)
        
        # This element is now disabled for the user, but not for marionette.
        x=self.marionette.find_element("id", "number_0")
        if x.is_enabled():
            print "IT'S ENABLED!"

Comment 2

[Roy Collings]

This seems to be working correctly now with this build:

unagi-ICS.eng.v1-train.Rel0.4.Sprint8.B-74.Gecko-0ab3418.Gaia-d5f7b2d.tgz

(i.e. when the image is 'disabled', clicking it does nothing ... as expected.)

Comment 3

[David Burns :automatedtester]

resolving after comment 2