Parallel JS: inlineUnsafeSetTypedArrayElement is busted

RESOLVED FIXED in mozilla23

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pnkfelix, Assigned: pnkfelix)

Tracking

unspecified
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The index calculations for `arri`, `idxi`, `elemi` are all busted in the code for IonBuilder::inlineUnsafeSetTypedArrayElement.  No one noticed since its dead code that can only be exposed via self-hosted calls to UnsafeSetElement on typed arrays, which we haven't attempted to do since many merges ago.
(Assignee)

Updated

5 years ago
Blocks: 801869
Created attachment 738599 [details] [diff] [review]
patch A v1: Fix inlineUnsafeSetTypedArrayElement to match other inlined array ops
Assignee: general → pnkfelix
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #738599 - Flags: review?(nmatsakis)
Attachment #738599 - Flags: review?(nmatsakis) → review+
(Assignee)

Updated

5 years ago
Attachment #738599 - Attachment is patch: true
try build: https://tbpl.mozilla.org/?tree=Try&rev=5b3e75aaf14b
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a12236dba85
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5a12236dba85
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.