Closed Bug 862933 Opened 7 years ago Closed 5 years ago

missing sentinel in function call to g_object_set in gfxPangoFonts

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: Ms2ger, Unassigned)

References

(Blocks 1 open bug)

Details

/builds/slave/try-lx-00000000000000000000000/build/gfx/thebes/gfxPangoFonts.cpp:908:52: error: missing sentinel in function call [-Werror,-Wsentinel]
        g_object_set(this, "fontmap", fontmap, NULL);
                                                   ^
                                                   , NULL
/usr/include/glib-2.0/gobject/gobject.h:411:10: note: function has been explicitly marked sentinel here
void        g_object_set                      (gpointer        object,
            ^
1 error generated.

https://tbpl.mozilla.org/?tree=Try&rev=296f9c618ba8

I suspect s/NULL/nullptr/ might fix the warning.

Note bug 547964, I guess.
Bug 810252 removed the relevant code:
https://hg.mozilla.org/mozilla-central/diff/03be241006e0/gfx/thebes/gfxPangoFonts.cpp#l1.488
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.