86299 - Cannot create nested folder in bookmark manager window

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Balazs Nagy]

One cannot create new folder when an open folder is highlighted which have only
open folders.

Comment 1

[doctor__j]

Confirmed on Win32 build 2001061610.

Here are the detailed repro steps:

1. Create bookmark folder "New Folder 1"
2. Create bookmark folder "New Folder 2".
3. Drag "New Folder 2" into "New Folder 1".
4. Create bookmark "foo" under "New Folder 2".
5. So you have such bookmark structure:

   New Folder 1
        |
        +--> New Folder 2
               |
               +--> Foo

6. Ensure the twisties are open for "New Folder 1" and "New Folder 2".
7. Select bookmark folder "New Folder 1".
8. Create bookmark folder "New Folder 3".

Actual results: Bookmark folder "New Folder 3" is not created.
Expected results: Bookmark folder "New Folder 3" is created.

Comment 2

[Chris Lyon]

I get the following JS error in the JS console when trying to create "New 
Folder 3":

Error: dummyItem is not defined
Source File: chrome://communicator/content/bookmarks/bookmarksTree.js
Line: 277

Comment 3

[Chris Lyon]

Changing OS to All and clarifying summary.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Nice catch. 

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 6

[Chris Lyon]

*** Bug 108484 has been marked as a duplicate of this bug. ***

Comment 7

[Paul Chen]

Attachment: Not sure what that selKid stuff was for, but this patch sets parentNode and relativeNode correctly

Comment 8

[Samir Gehani]

Comment on attachment 58679 [details] [diff] [review]
Not sure what that selKid stuff was for, but this patch sets parentNode and relativeNode correctly

r=sgehani  

Unrelated, but could we remove the alert()s from doBookmarkCommand() while
checking this in?  Thanks.

Comment 9

[Paul Chen]

I removed the alerts in the fix for 102311

Comment 10

[[not reading bugmail]]

alert are in Browser Window > Bookmarks > File Bookmark > Open Personal Toolbar
folder > Create a new Folder > 'enter in a folder name here' > ok   then two
alerts popup NC:BookmarkRoot and NC:$'some garbage string'  

build 11-27-2001  W2K

-dennis

Comment 11

[[not reading bugmail]]

can attach a screen shot if you like for the alerts here, but there are a few
comments floating here there for NC:BookmarkRoot problems.. and weird alerts
that maybe we need to reopen and then get them all patched up, before marking
fixed again.

Comment 12

[Chris Lyon]

Dennis, the alerts when creating a new bookmark folder is bug 108794.

Please try to keep it to one issue per bug report.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 58679 [details] [diff] [review]
Not sure what that selKid stuff was for, but this patch sets parentNode and relativeNode correctly

sr=[e-mail]

Comment 14

[Paul Chen]

fix checked into trunk

Comment 15

[[not reading bugmail]]

Chris,

not a problem.  Thanks for the heads up.  I had a hard time finding the bugzilla
#'s for these, and it appeared to myself that maybe they were being ignored
after some alerts were fixed up, So I was just trying to bring it up as a FYI. 
So thanks.

Dennis

Comment 16

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]