Closed
Bug 863076
Opened 11 years ago
Closed 9 years ago
Some NSS files still contain the old triple license
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.17.4
People
(Reporter: KaiE, Assigned: gerv)
Details
Attachments
(2 files)
11.15 KB,
patch
|
KaiE
:
review+
KaiE
:
checked-in+
|
Details | Diff | Splinter Review |
10.80 KB,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
$ grep -rl "Version: MPL 1.1/GPL 2.0/LGPL 2.1" nss/ nss/pkg/solaris/common_files/copyright nss/lib/freebl/ecl/README nss/lib/freebl/mpi/utils/README nss/lib/freebl/mpi/utils/LICENSE-MPL nss/lib/freebl/mpi/README nss/lib/freebl/mpi/doc/LICENSE-MPL nss/lib/freebl/mpi/tests/LICENSE-MPL nss/tests/iopr/server_scr/config nss/tests/chains/scenarios/scenarios nss/tests/libpkix/sample_apps/README
Assignee | ||
Comment 1•11 years ago
|
||
Kai: thanks for this. Can you confirm that none of these files are part of or refer to an imported 3rd party library which still uses those licensing terms? Gerv
Comment 2•11 years ago
|
||
For nss/pkg/solaris/common_files/copyright is our own code. The best solution may be to remove the entire nss/pkg directory. It was used by Sun before. We'll need to contact the current maintainers of those Sun products. nss/lib/freebl/ecl is our own code. nss/lib/freebl/mpi is third-party code. I remember Nelson asked the author of mpi to contribute his code to NSS under the triple-license used by NSS at that time. nss/tests is our own code.
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Wan-Teh Chang from comment #2) > For nss/pkg/solaris/common_files/copyright is our own code. The best > solution may be to remove the entire nss/pkg directory. It was used > by Sun before. We'll need to contact the current maintainers of those > Sun products. OK. I will leave that to you :-) Please let me know the outcome. > nss/lib/freebl/mpi is third-party code. I remember Nelson asked the > author of mpi to contribute his code to NSS under the triple-license > used by NSS at that time. OK. Is it still maintained elsewhere? If so, where and under what licence? Or are we now effectively the maintainers? Gerv
Comment 4•11 years ago
|
||
Gerv: Let me clarify this. nss/lib/freebl/mpi is our fork of third-party code. When we created our fork, Nelson asked the author of MPI to contribute the MPI code to NSS under the triple license used by NSS at that time.
Assignee | ||
Comment 5•11 years ago
|
||
OK, thank you. I suggest that we simply update all these files with the new boilerplate from http://www.mozilla.org/MPL/headers/. I will try and get around to making a patch but it might be a while; if someone else gets to it meantime, so much the better :-) Gerv
Updated•11 years ago
|
Priority: -- → P2
Target Milestone: --- → 3.15.1
Updated•11 years ago
|
Target Milestone: 3.15.1 → 3.15.2
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8540214 [details] [diff] [review] Patch v.1 Thanks Gerv, but the patch seems incomplete. Nevertheless, r=kaie for the existing changes.
Attachment #8540214 -
Flags: review?(kaie) → review+
Reporter | ||
Comment 8•9 years ago
|
||
The remaining files are: nss/tests/iopr/server_scr/config nss/tests/chains/scenarios/scenarios nss/lib/freebl/mpi/utils/LICENSE-MPL nss/lib/freebl/mpi/doc/LICENSE-MPL nss/lib/freebl/mpi/tests/LICENSE-MPL I could make a patch for the remaining files, for you to review.
Reporter | ||
Comment 9•9 years ago
|
||
Comment on attachment 8540214 [details] [diff] [review] Patch v.1 https://hg.mozilla.org/projects/nss/rev/fb546430479b
Attachment #8540214 -
Flags: checked-in+
Reporter | ||
Comment 10•9 years ago
|
||
Attachment #8549815 -
Flags: review?(gerv)
Assignee | ||
Updated•9 years ago
|
Attachment #8549815 -
Flags: review?(gerv) → review+
Reporter | ||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/da9dda81ae6f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: 3.15.2 → 3.18
Reporter | ||
Comment 12•9 years ago
|
||
mass change target milestone to 3.17.4
Target Milestone: 3.18 → 3.17.4
You need to log in
before you can comment on or make changes to this bug.
Description
•