Closed Bug 863093 Opened 11 years ago Closed 10 years ago

The usermatchmode parameter no longer exists. The POD for User.get must be fixed accordingly

Categories

(Bugzilla :: WebService, defect)

3.6.13
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(1 file)

The documentation for the User.get API says that:

"Some Bugzilla installations have user-matching turned off, in which case you will only be returned exact matches.

Most installations have a limit on how many matches are returned for each string, which defaults to 1000 but can be changed by the Bugzilla administrator."


First of all, the usermatchmode parameter is gone since Bugzilla 3.6, see bug 399089. So the first sentence is obsolete.

Also, the 2nd sentence makes us think that User.get follows the maxusermatches parameter, but it ignores it completely. The description of this parameter is:

"If set to '1', no users will be displayed on ambiguous matches. This is useful for user privacy purposes."

But it only applies to the web UI, not to the WebServices. Either we indeed don't care about this limitation and the 2nd sentence must go away, or it's a bug and it must be fixed.

Thoughts?
Summary: The usermatchmode no longer exists. The POD for User.get must be fixed accordingly → The usermatchmode parameter no longer exists. The POD for User.get must be fixed accordingly
Attached patch patch, v1Splinter Review
Now that bug 962060 is fixed, the patch is trivial.
Assignee: webservice → LpSolit
Status: NEW → ASSIGNED
Attachment #8382912 - Flags: review?(dkl)
Target Milestone: Bugzilla 4.0 → Bugzilla 4.4
Comment on attachment 8382912 [details] [diff] [review]
patch, v1

Review of attachment 8382912 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8382912 - Flags: review?(dkl) → review+
Flags: approval?
Flags: approval4.4?
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/WebService/User.pm
Committed revision 8939.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/WebService/User.pm
Committed revision 8666.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: