863099 - [SeaMonkey] TEST-UNEXPECTED-FAIL | browser_ApplicationPrefs.js | Check existing boolean property for existence

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank Wein [:mcsmurf]]

Bug 857820 removed the browser.blink_allowed pref, we need to fix the browser_ApplicationPrefs.js test because of that:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/smile/test/browser_ApplicationPrefs.js | Check existing boolean property for existence
Stack trace:
    JS frame :: chrome://mochitests/content/browser/suite/smile/test/browser_ApplicationPrefs.js :: test :: line 97
    JS frame :: chrome://mochikit/content/browser-test.js :: Tester_execTest :: line 402
    JS frame :: chrome://mochikit/content/browser-test.js :: Tester_nextTest/< :: line 343
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[Frank Wein [:mcsmurf]]

Pushed the patch to comm-central without review as it's a really trivial test fix: https://hg.mozilla.org/comm-central/rev/09c9f84de3e1

Comment 3

[Philip Chee]

You need to fix the comment as well.

>   // PREF: boolean browser.blink_allowed == true
> 
>   // test to see if an existing boolean property exists
>   ok(Application.prefs.has(testdata.boolean), "Check existing boolean property for existence");

Comment 4

[Frank Wein [:mcsmurf]]

Yeah...will be fixed when I'll land another patch.

Comment 5

[Frank Wein [:mcsmurf]]

Pushed the comment fix to comm-central: https://hg.mozilla.org/comm-central/rev/27503b22e289