Closed Bug 863101 Opened 7 years ago Closed 7 years ago

Polish - make tiles in panels work in snapped

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect)

x86_64
Windows 8
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ally, Assigned: ally)

Details

Attachments

(2 files)

make the tiles in the panels (bookmarks, history, synced tabs, etc) behave like the autocomplete tiles & topsites tiles in snapped view

We also want to make the containers scrollable, so people can get to more than one row of sites. :)
- titles that (mostly) fit in snapped
-- Tabs from other devices is too long to fit. A smaller font & the titles are smaller than the text of the tiles
- tiles are laid out like snapped start view, 
- grid also indicates to the user that this can be scrolled, as edges of other tabs are just visible on the right edge
-- bookmarks is the best example of this
- padding is reduced so one can see the url on the tile
- the scrollable area is larger (before it was only the right most 3/4 inch on my vaio. Not fun & difficult to use)
Attachment #739692 - Flags: review?(rsilveira)
Comment on attachment 739692 [details] [diff] [review]
draft 0, part 1/1

Review of attachment 739692 [details] [diff] [review]:
-----------------------------------------------------------------

It's much more usable with your patch, thanks! Mostly nits.

::: browser/metro/base/content/browser.xul
@@ +350,4 @@
>          </menulist>
>        </hbox>
>  
> +      <deck id="panel-items" selectedIndex="0" flex="1"  >

nit: remove extra space at the end.

@@ +362,2 @@
>          </scrollbox>
> +        <scrollbox id="remotetabs-container" class="canSnapTiles" flex="1">

Your selector would still work, but move the class to the richgrid for consistency.

::: browser/metro/theme/browser.css
@@ +901,5 @@
> +#panel-container[viewstate="snapped"] .canSnapTiles .richgrid-item-content {
> +  -moz-box-orient: horizontal;
> +}
> +
> +

nit: extra line
Attachment #739692 - Flags: review?(rsilveira) → review+
https://hg.mozilla.org/mozilla-central/rev/3b8a036e8beb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.