Closed Bug 863116 Opened 7 years ago Closed 7 years ago

Stuff is getting inlined in debug builds

Categories

(Core :: JavaScript Engine, defect, blocker)

defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: billm, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
+++ This bug was initially created as a clone of Bug #843402 +++

I was trying to use the isMarked method on a Cell today while in the debugger and it didn't work because that function is marked as JS_ALWAYS_INLINE. My only alternative was to laboriously compute the correct bit in the mark bitmap myself and do the masking. This is unacceptable.

This patch ensures that JS_ALWAYS_INLINE does not inline in debug builds, except for some weird ones that ASan needs to be inlined.
Attachment #738837 - Flags: review?(jwalden+bmo)
This has been bugging several of us now for a while; we just didn't know what had changed.
Comment on attachment 738837 [details] [diff] [review]
patch

Review of attachment 738837 [details] [diff] [review]:
-----------------------------------------------------------------

Fine, I guess this cuts it.
Attachment #738837 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/e88b1aab80c3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.