863127 - (REGIONAL) The lockscreen shows the Service provider name twice (for all Movistar LATAM countries)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[John Hammink]

Issue reported in certification for LatAm (adding deps). 

Buildid "20130321070205", device: ikura
gecko commit: b5183c99228bdc5be33340e359efd1b4f0859e92 
gaia commit: 577d13088ebdbd353d13910d3317e713a140415b

STR:
Boot up the phone with any Movistar LATAM country SIM card inserted.

Actual:
Lock screen shows the Service Provider Name twice, e.g. "movistar movistar"


Expected:
SPN should be shown only once.



NOTE:  Certification refers to Annex 59

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

It would be nice to get the following information from someone who is in LATAM (insert in 'shared/js/mobile_operator.js' line 11):

    console.log('userFacingInfo icc', operator,
      iccInfo.isDisplaySpnRequired, 
      iccInfo.isDisplayNetworkNameRequired, 
      iccInfo.spn);

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Proposed patch to omit SPN if same as network name

Proposed fix. If SPN and network name are required but they are the same then we get weird results here, like movistar movistar. This patch omits the SPN if it's the same as the network name.

Tim, I've attached you as the reviewer because I don't really know who would be appropriate for it, please forward if necessary.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 738948 [details] [diff] [review]
Proposed patch to omit SPN if same as network name

I just check spec TS 131.102,
it doesn't say we still need to display both SPN and operator even they're the same.

I think janjongboom's patch is fine.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 738948 [details] [diff] [review]
Proposed patch to omit SPN if same as network name

Looks good, thanks!

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/dc4d70cac4abed8c3ca32822a9e171c6a05d5f34

Comment 7

[James Lal [:lightsofapollo]]

This bug was partially uplifted.

Uplifted dc4d70cac4abed8c3ca32822a9e171c6a05d5f34 to:
v1-train: f9c868fd62b0ea0c4363c85120b2511e48204069

Commit dc4d70cac4abed8c3ca32822a9e171c6a05d5f34 didn't uplift to branch v1.0.1

Comment 8

[Daniel Coloma:dcoloma]

Jan, can you please help with the uplift to v1.0.1?

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: v1.0.1 patch

Attached PR that merges against v1.0.1

Comment 10

[Juan Perez-Bedmar [:juanpbf]]

Hi, I have tested the latest nightly build for Ikura: 
build ID:20130426165700
build information:
gaia commit:
e25b349 Merge pull request #9273 from gasolin/issue-863126
gecko commit:
6dfd179 Bug 849757 - Part 4: xpcshell tests. r=vicamo, a=tef+
AU:V1.01.00.01.019.085

and the issue is still reproducible. 
When is the ETA for this patch to be uplifted?
BR

Comment 11

[Daniel Coloma:dcoloma]

John, can you please uplift this to 1.0.1?

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 696b2eb

Comment 13

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 742951 [details] [diff] [review]
v1.0.1 patch

Setting r+ because already landed.