863154 - java.lang.OutOfMemoryError: at android.graphics.BitmapFactory.nativeDecodeStream(Native Method) at org.mozilla.gecko.Favicons$LoadFaviconTask.downloadFavicon(Favicons.java) on ICS and above

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It's #200 crasher in 20.0.1 and #60 in 21.0b2.

Here is a crash report: bp-2c1d5de6-063c-4810-b62f-464b72130418.

java.lang.OutOfMemoryError
	at android.graphics.BitmapFactory.nativeDecodeStream(Native Method)
	at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:529)
	at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:601)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.downloadFavicon(Favicons.java:270)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:318)
	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:201)
	at android.os.AsyncTask$2.call(AsyncTask.java:287)
	at java.util.concurrent.FutureTask.run(FutureTask.java:234)
	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
	at java.lang.Thread.run(Thread.java:856)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.OutOfMemoryError%3A+at+android.graphics.BitmapFactory.nativeDecodeStream%28Native+Method%29

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

I could reproduce this consistently at http://www.cs.tut.fi/~jkorpela/forms/ on Nightly.

Comment 2

[Chris Peterson [:cpeterson]]

This bitmap OOM is related to bug 863288.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: part-1-catch-decodeStream-oom.patch

Part 1: Catch Bitmap OOMs when decoding streams.

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: part-2-catch-decodeResource-oom.patch

Part 2: Catch Bitmap OOMs when decoding resources.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Nice cleanup.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 746720 [details] [diff] [review]
part-2-catch-decodeResource-oom.patch

Now that we are returning null for failures, we might starting seeing other types of crashes that we need to "null check" to victory.

Comment 7

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/814044b7f853
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae87f942ac08

Comment 8

[Chris Peterson [:cpeterson]]

Comment on attachment 746719 [details] [diff] [review]
part-1-catch-decodeStream-oom.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: No change in the number of OOM crashes.
Testing completed (on m-c, etc.): Test locally with 100% repro test case.
Risk to taking this patch (and alternatives if risky): Low risk because it mostly consolidates some error handling and catches OOM exceptions.
String or IDL/UUID changes made by this patch: N/A

Comment 9

[Chris Peterson [:cpeterson]]

Comment on attachment 746720 [details] [diff] [review]
part-2-catch-decodeResource-oom.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: No change in the number of OOM crashes.
Testing completed (on m-c, etc.): Test locally with 100% repro test case.
Risk to taking this patch (and alternatives if risky): Low risk because it mostly consolidates some error handling and catches OOM exceptions.
String or IDL/UUID changes made by this patch: N/A

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/814044b7f853
https://hg.mozilla.org/mozilla-central/rev/ae87f942ac08

Comment 11

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f88517aed561
https://hg.mozilla.org/releases/mozilla-aurora/rev/f1914db3cd0c