863158 - Links in plaintext emails/e-mails don't open in browser if tapped

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Gaia 1.1.0.0-pre 20130417070204, Unagi

Tapping links in plaintext emails (Mozilla's Try server confirmation, bug mail) doesn't open in the browser, nothing happens. Tapping a link in a HTML mail asks if I want to open it in the browser.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

This was regressed by deferred body loading's introduction of a progress spinner that regrettably faked out a naive heuristic.  Fix identified and coming shortly.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9298

Pointer to Github pull-request

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

landed in gaia/master:
https://github.com/mozilla-b2g/gaia/pull/9298
https://github.com/mozilla-b2g/gaia/commit/f9b6693f2a1c7254ecd2ae7ae5035f0f559ae7f2

Comment 4

[James Lal [:lightsofapollo]]

Uplifted f9b6693f2a1c7254ecd2ae7ae5035f0f559ae7f2 to:
v1-train: 1f913987453f00e818bff2a2eda3b9c0033cec62
v1.0.1: 35e2129ef810bb3fccefa50a74995242048baea1

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

I'm still getting this issue on Inari, v1.0.1 Commercial RIL
Gaia   052253176f3ad495a1086e47a28fffbf07613388
BuildID 20130425070201
Version 18.0

Pop-up appears when I click on a link in an email, but browser doesn't show up, neither does link load

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

see comment 5

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Can someone confirm if this is also not fixed on v1.1?

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

I just re-tested with current gaia/v1.0.1 and gaia/v1-train and both plaintext and HTML linkification and clicking on them work fine.

The most likely explanation for difficulty causing links to pop up would be the fundamental problem where the clickable link area tends to be much smaller than your finger, and it's very possible the click point is occurring outside the link.  Assuming we are getting any of the benefit of hit area inflation, we are probably only getting it for linkified text/plain mails.

For text/html messages we end up using elementFromPoint because we have to invert the scale operation because of our use of an iframe with script disabled, so we are almost certainly not getting the benefit of hit area inflation, which can make it very difficult to click on links for HTML messages.  This is potentially offset by the ability to zoom into newsletter-mode HTML messages.

We could always implement a search pattern when using elementFromPoint to try and increase the hit success rate of clicking on links, but that's decidedly a different bug from what this bug was.

I'm gong to leave qawanted open for now since it's possible there's some issue I'm simply not seeing, but QA should please be very clear about what type of email is being tested (text/plain versus text/html) and that clicks were comprehensively tried, potentially including use of a stylus or something like that that makes it easier to click on things.

Comment 9

[Sarah Parsons]

Verified fixed on Inari Build ID: 20130503070205
Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3f3489356bbc
Gaia: 3e232bce289c9e156d92553e752616cba284bc8f

Also verified fixed on Unagi Build ID: 20130503070205
Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3f3489356bbc
Gaia: 3e232bce289c9e156d92553e752616cba284bc8f

Link received in an email work properly, browser will open and page will load.

Comment 11

[Sayak Sarkar]

Seems like the fix for 1.0.1 is yet to land as an OTA update for Keon as the issue still persists on the latest stable build available on the Keon [Boot2Gecko 1.0.1.0 pre-release].