Closed
Bug 863181
Opened 12 years ago
Closed 12 years ago
[Settings][Call Settings] the 'timeSeconds' for no_reply call forwarding dose not be set correctly
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edgar, Assigned: jaoo)
Details
Attachments
(1 file)
I found Gaia pass call forwarding object with 'timeSecond' property to call forwarding API [1].
But actually it should be 'timeSeconds' [2].
[1] https://github.com/mozilla-b2g/gaia/blob/b65dbaace1bfc940db6f10aee6ad3c54187d25aa/apps/settings/js/call.js#L369
[2] https://github.com/mozilla/mozilla-central/blob/0840a99cdebcf94b7ffee3caecd2d07961bdae00/dom/network/interfaces/nsIDOMMobileConnection.idl#L547
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → josea.olivera
|
|
Assignee | |
Comment 1•12 years ago
|
||
Arthur, just a small change that was causing an issue when setting up call forwarding. Thanks Edgar who was the one that found it. Could you take a look please? Thanks! (No rush with it please, this's not so critical IMHO).
Attachment #766668 -
Flags: review?(arthur.chen)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 766668 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/10577
Jose, thanks for the patch! r=me.
Attachment #766668 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•