Abstract Contacts.findBy to be parameterized rather than having multiple findByX methods

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: janjongboom, Assigned: rwaldron)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

In bug 856991 a new method was introduced to find contacts, we should abstract the way we search for contacts to a more generic way instead of keep adding methods as proposed by :rwldrn
(Assignee)

Updated

5 years ago
Assignee: nobody → waldron.rick
(Assignee)

Comment 1

5 years ago
I'm assuming since you didn't assign this to yourself that you don't mind me taking it. If that's not the case please let me know
This is not part of SMS/MMS, it's part of /shared stuff that could be applied to SMS. We are not going to block on 'refactor' stuff while having all MMS bugs. That's why I've moved to 'Gaia' common stuff. Once you have the code in 'shared' and well tested we could apply to SMS in other bug.
Component: Gaia::SMS → Gaia
(Assignee)

Comment 3

5 years ago
@Borja, it's absolutely not part of /shared; Contacts.findBy* code is located in the file at /apps/sms/js/contacts.js
(Assignee)

Updated

5 years ago
Component: Gaia → Gaia::SMS
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.