863226 - Port bugfixes (and possibly some improvements) to the log tree from Instantbird

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[aleth [:aleth]]

There have been some bugfixes to the log tree in Instantbird which won't be merged automatically, as the log viewer code is forked.

Bug 1732:
- Select first entry in the log tree on opening the log window even if the
first entry is not a group.

Bug 1926
- "Last week"-group in log viewer contains one day too many

There have also been some changes to the log tree for Instantbird which may also be improvements wanted for TB, but I'd like some feedback from TB users before porting those.

Bug 1732:
- Instead of putting all the logs older than 2 weeks in a single group, they are now grouped by month.

Bug 1922:
- Use weekdays instead of dates for "last week" group entries

Bug 1933:
- Rename the "Last week" group to "This week", and the "Two weeks ago" group to "Last week". (This may be confusing to existing TB users.)

Comment 1

[aleth [:aleth]]

Bug 2612 -  Section scroll doesn't find all sessions

Comment 2

[aleth [:aleth]]

(In reply to aleth from comment #1)
> Bug 2612 -  Section scroll doesn't find all sessions
Should be bug 2061.

Comment 3

[Patrick Cloke [:clokep]]

aleth, were these part of bug 920801 or do they still need to be ported?

Comment 4

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #3)
> aleth, were these part of bug 920801 or do they still need to be ported?

They still need to be ported.

Comment 5

[aleth [:aleth]]

Now bug 955162, bug 955363, bug 8353491, bug 955359, bug 955371, bug 8353821.

Comment 6

[aleth [:aleth]]

Bug 955498, that should have been.

Comment 7

[aleth [:aleth]]

Attachment: 863226.patch

Straightforward port of the patches described in comment 0.

Does this require UI-review?

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8367282 [details] [diff] [review]
863226.patch

I haven't tested this myself, but the code seems OK, and it's according to the comment a straight port, so assuming you have tested this (which you confirmed on IRC :)), I don't think we should delay it further. Sorry for the already long delay.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/68d3a6771ee3