Closed Bug 863324 Opened 7 years ago Closed 7 years ago

Rename PLayers into PLayerTransaction

Categories

(Core :: Graphics: Layers, defect)

23 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(1 file, 2 obsolete files)

PLayers is a bad name because it is very close to the existing PLayer and spawns files like ShadowLayersChild.cpp/h and ShadowLayersParent.cpp/h that look very much like ShadowLayerChild.cpp/h and ShadowLayerParent.cpp/h

We already have CompositableTransactionParent.cpp that does what ShadowLayersParent.cpp does, but for compositables, so it makes sense for Players.ipdl to become PLayerTransaction.ipdl, and therefore ShadowLayers{Parent/Child}.{cpp/h} to become LayerTransaction[Child/Parent].[cpp/h]
Attachment #739138 - Flags: review?(jmuizelaar)
Same patch with bad indentation fixed.
Attachment #739138 - Attachment is obsolete: true
Attachment #739138 - Flags: review?(jmuizelaar)
Attachment #740256 - Flags: review?(jmuizelaar)
There was more indentation to fix, sorry for the spam.
Attachment #740256 - Attachment is obsolete: true
Attachment #740256 - Flags: review?(jmuizelaar)
Attachment #740262 - Flags: review?(jmuizelaar)
Attachment #740262 - Flags: review?(jmuizelaar) → review+
Got backed out for fennec bustage, fixed the build error and re-landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/fdaa0659fe13
Well, Fennec is already busted with your patch :(  I backed it out again.  Please test on try next time?

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c798562d74c
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #7)
> Well, Fennec is already busted with your patch :(  I backed it out again. 
> Please test on try next time?

I did, it gets bitrot pretty quickly unfortunately.

I made sure it passed try again yesterday and relanded

https://hg.mozilla.org/integration/mozilla-inbound/rev/08ebffd7bc4d
https://hg.mozilla.org/mozilla-central/rev/08ebffd7bc4d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.