863334 - l10n shipping tools for a Fennec milestone should have android-multilocale in the default output of l10n-changesets.json

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P2)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

When you go to https://l10n.mozilla.org/shipping/about-milestone/fennec21_beta_b3
for example, and click on Shipping Tools then you have to do the following: https://wiki.mozilla.org/images/thumb/2/24/Explicit_fennec_changesets.png/800px-Explicit_fennec_changesets.png  otherwise clicking on l10n-changesets.json only outputs 'android' locales & changesets.

It seems we never do builds without android-multilocale, so those should be included in the default, to prevent their absence (as happened with FF21.0b2) and so that there are fewer steps when going to build. If someone needs to adjust a l10n-changeset.json to not follow this default pattern, they can do so manually (for now) until there might be options to both add and remove other platforms from the changesets file generated.

Assigning this to Axel since afaik he's the only person who can work on changes to this tool/site - if another person is able to do it then re-assign accordingly.

Given that this is a FF20 post mortem action, I'm setting tracking so that we stay on this and resolve it within the next two release cycles since this is quite a small change.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

I've submitted a pull request that should do this - r? https://github.com/mozilla/elmo/pull/6

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Add android-multilocale as a default in l10n-changesets 'platforms'

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 740360 [details] [review]
Add android-multilocale as a default in l10n-changesets 'platforms'

Lukas, thanks for the patch. Sadly, just changing the platforms won't work, the trick is to synthesize a click on the "add" button.

Should be done by calling addMulti() in https://github.com/mozilla/elmo/blob/develop/apps/shipping/static/shipping/js/about-milestone.js#L29

Technically, we're developing with git flow, which means, we need pull requests against the 'develop' branch.

Comment 4

[Axel Hecht [:Pike]]

Attachment: pretend the button was clicked

Peter, this avoids that relman can forget to click the button, so it just does that in the onload handler.

This code is used in about-milestone, in the shipping details to create the json export.

Comment 5

[Peter Bengtsson [:peterbe]]

Comment on attachment 740788 [details] [diff] [review]
pretend the button was clicked

Review of attachment 740788 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a small nit about lack of comment why

::: apps/shipping/static/shipping/js/about-milestone.js
@@ +27,4 @@
>      return false;
>    });
>    $("#add-multi").click(addMulti);
> +  addMulti();

This is rather surprising to see in code if you don't know the reason or context. 

Perhaps a little comment that explains why it's triggered on dom load.

Comment 6

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/0c772e6f075c0db3998e8bc7e90902f27704bc47
bug 863334, make android-multi show up by default, r=peterbe.
Let's focus this export on mobile, and make the first button press happen
by default

Comment 7

[Axel Hecht [:Pike]]

This is FIXED and deployed in production.