863335 - Download Update via data screen update

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Eric Pang [:epang] UX]

Attachment: Download via data mock ups

Pavel,

I've created a mock up for layout and font updates for this screen.  Also note that I've removed the download icon.  Can you work on this? Let me know if you have any questions, thanks!

Comment 1

[Eric Pang [:epang] UX]

Attachment: Font Specs

Comment 2

[Sergi]

Eric, why are we using a padding of 25px for the divider instead of 15px? we're using 15px everywhere else on the device. Is this a special case? 

Thanks!

Comment 3

[Eric Pang [:epang] UX]

(In reply to Sergi from comment #2)
> Eric, why are we using a padding of 25px for the divider instead of 15px?
> we're using 15px everywhere else on the device. Is this a special case? 
> 
> Thanks!

Hi Sergi,  I've been using the Specs from the wiki:
https://wiki.mozilla.org/File:OWD_00_Confirm_Sample.jpg

The confirmation screens on the wiki have 25px margins for the div lines and a left margin of 30px for the text.  

Let me know if this is incorrect.  If so, can you point me to a final spec I can follow.

Thanks!

Comment 4

[Sergi]

I'm afraid that's incorrect. I've updated it in the wiki:https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Confirm

Do you want me to replace the sample you provided in this bug?

Thanks!

Comment 5

[Eric Pang [:epang] UX]

Hi Sergi, 
Looks like my browser was caching and I was looking at the outdated specs, sorry!

Now i see the specs:

15px padding for div liens
30px padding for text

Is this something we can update in the building blocks to make all screens of this type consistent?  Let me know if it's possible...i hope it is!

Thanks!

Comment 6

[Sergi]

Yes. I think it won't be a problem. 

I'm adding Arnau to the conversation and will also talk with him offline to get this done asap.

Thank you very much Eric

Comment 7

[Eric Pang [:epang] UX]

(In reply to Sergi from comment #6)
> Yes. I think it won't be a problem. 
> 
> I'm adding Arnau to the conversation and will also talk with him offline to
> get this done asap.
> 
> Thank you very much Eric

No Problem, for now I'm updating any mock ups I've created within the last couple of weeks that have not yet been worked on with the new building blocks (15px padding).  Will attach one here shortly too :).  Thanks for bringing this to my attention Sergi!

Comment 8

[Eric Pang [:epang] UX]

Attachment: Download via data mock up

Updated padding of div lines to 15px (to match revised building blocks)

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch

Comment 10

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Info for reviewers:
css in bb/value_selector.css was overwriting values in Confirm Building block.
I have added data-type="value-selector" to avoid it, and also removed unneeded styles in style/modal_dialog/prompt.css and style/update_manager/update_manager.css.

Comment 12

[Ismael Gonzalez [:basiclines]]

Comment on attachment 741294 [details]
patch

Everything looks fine to me :D

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 741294 [details]
patch

CSS only change, r=me.

Comment 14

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 741294 [details]
patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: incorrect layout visualization
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low, only CSS changed
String or UUID changes made by this patch:

Comment 15

[Maria Angeles Oteo (:oteo)]

Nominating tef? as his duplidated is tef+

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Can we please close the bug and also put in the commit of when it was committed?

Committed : 
Apr 26, 2013
https://github.com/rnowm/gaia/commit/e69553c36894979e0be587fe2b172a8b6795d803

This was put in a while ago to master.

Verified on : 
Build ID : 2013-04-30-03-10-46
"mozilla-central" revision="dd0c611a0a27"
"gecko.git" revision="0050771e43cf27a7728710c0bbf44035528dc341"

Comment 17

[Eric Pang [:epang] UX]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #16)
> Can we please close the bug and also put in the commit of when it was
> committed?
> 
> Committed : 
> Apr 26, 2013
> https://github.com/rnowm/gaia/commit/e69553c36894979e0be587fe2b172a8b6795d803
> 
> This was put in a while ago to master.
> 
> Verified on : 
> Build ID : 2013-04-30-03-10-46
> "mozilla-central" revision="dd0c611a0a27"
> "gecko.git" revision="0050771e43cf27a7728710c0bbf44035528dc341"

Thanks for verifying Naoki!

Comment 18

[Sam Joch [:samjoch]]

Arnau, can you request for an approval-gaia-v1 ?

Comment 19

[Sam Joch [:samjoch]]

Oops sorry already requested in comment 14 (https://bugzilla.mozilla.org/show_bug.cgi?id=863335#c14)

Comment 20

[Maria Angeles Oteo (:oteo)]

I already removed gaia-approval-v1 request last week as this is a tef+ bug.
Tef+ bugs don't need gaia-approval-v1+

Comment 21

[Sam Joch [:samjoch]]

Didn't know that thanks Maria.

Comment 22

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  e69553c36894979e0be587fe2b172a8b6795d803
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train --pretty=%H)

Comment 23

[Eric Pang [:epang] UX]

(In reply to John Ford [:jhford] -- If you expect a reply from me, use needsinfo? instead of CC from comment #22)
> I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has
> dependencies which are not marked in this bug, please comment on this bug. 
> If this bug depends on patches that aren't approved for v1-train and v1.0.1,
> we need to re-evaluate the approval.  Otherwise, if this is just a merge
> conflict, you might be able to resolve it with:
> 
>   git checkout v1-train
>   git cherry-pick -x  e69553c36894979e0be587fe2b172a8b6795d803
>   <RESOLVE MERGE CONFLICTS>
>   git commit
>   git checkout v1.0.1
>   git cherry-pick -x $(git log -n1 v1-train --pretty=%H)

Arnau, can you please look into this? Thanks!

Comment 24

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Cherrypicking done! Thanks

Comment 25

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

v1.01 3e232bce289c9e156d92553e752616cba284bc8f
v1-train b0aca0dd1e2955e11190ede725e1fb9ee596438b