Closed
Bug 863365
Opened 13 years ago
Closed 13 years ago
Log a message when linking libxul with make -s
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
2.08 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
So, uh, let's say I found this patch somewhere, and I thought it would be useful... I deny having had anything to do with its creation, though. I don't have the build system chops to do such a thing.
Attachment #739184 -
Flags: review?(gps)
| Assignee | ||
Comment 1•13 years ago
|
||
Oh, and:
138:04.09 nsUnicodeProperties.cpp
138:04.26 nsRDFResource.cpp
138:06.86 libxul.so
148:08.33 nsGnomeModule.cpp
148:08.52 nsGConfService.cpp
is what we get.
Comment 2•13 years ago
|
||
Comment on attachment 739184 [details] [diff] [review]
Patch v1
Review of attachment 739184 [details] [diff] [review]:
-----------------------------------------------------------------
+1000. Would review again.
Given how long it takes to link some shared libraries, I almost wonder if we should add a "finished" message as well. I guess this patch is better than nothing. There's always follow-ups.
Note that this will result in extra logging for non-silent builds. Meh.
Attachment #739184 -
Flags: review?(gps) → review+
| Assignee | ||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•