863392 - B2G crash: assert failure in ~ImageLayerComposite: mDestroyed is not true as expected.

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

I get this quite often on B2G post-layers-refactoring (BRANCH=master):

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 109.257]
0x41ee232c in ~ImageLayerComposite (this=0x495e7800, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/composite/ImageLayerComposite.cpp:36
36        MOZ_ASSERT(mDestroyed);
(gdb) bt
#0  0x41ee232c in ~ImageLayerComposite (this=0x495e7800, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/composite/ImageLayerComposite.cpp:36
#1  0x41ee23ae in ~ImageLayerComposite (this=0x75, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/composite/ImageLayerComposite.cpp:39
#2  0x41ee1302 in mozilla::layers::Layer::Release (this=<value optimized out>, aChild=0x495e7890)
    at /hack/mozilla-central/gfx/layers/Layers.h:593
#3  mozilla::layers::ContainerLayerComposite::RemoveChild (this=<value optimized out>, 
    aChild=0x495e7890)
    at /hack/mozilla-central/gfx/layers/composite/ContainerLayerComposite.cpp:246
#4  0x41ee13ae in ~ContainerLayerComposite (this=0x49509400, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/composite/ContainerLayerComposite.cpp:176
#5  0x41ee1422 in ~ContainerLayerComposite (this=0x75, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/composite/ContainerLayerComposite.cpp:178
#6  0x41ee1302 in mozilla::layers::Layer::Release (this=<value optimized out>, aChild=0x49509490)
    at /hack/mozilla-central/gfx/layers/Layers.h:593
#7  mozilla::layers::ContainerLayerComposite::RemoveChild (this=<value optimized out>, 
    aChild=0x49509490)
    at /hack/mozilla-central/gfx/layers/composite/ContainerLayerComposite.cpp:246
#8  0x41ee13ae in ~ContainerLayerComposite (this=0x4950b400, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/composite/ContainerLayerComposite.cpp:176
#9  0x41ee1422 in ~ContainerLayerComposite (this=0x75, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/composite/ContainerLayerComposite.cpp:178
#10 0x40fd62ae in mozilla::layers::Layer::Release (this=0x4950b490)
    at ../../dist/include/Layers.h:593
#11 0x41efcd82 in ~nsRefPtr (this=0x48157510, __in_chrg=<value optimized out>)
    at ../../dist/include/nsAutoPtr.h:880
#12 ~ShadowLayersParent (this=0x48157510, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/ipc/ShadowLayersParent.cpp:142
#13 0x41efcdba in ~ShadowLayersParent (this=0x75, __in_chrg=<value optimized out>)
    at /hack/mozilla-central/gfx/layers/ipc/ShadowLayersParent.cpp:142
#14 0x41ef30d2 in mozilla::layers::CrossProcessCompositorParent::DeallocPLayers (
    this=<value optimized out>, aLayers=0x48157510)
    at /hack/mozilla-central/gfx/layers/ipc/CompositorParent.cpp:1384
#15 0x41acf6da in mozilla::layers::PCompositorParent::DeallocSubtree (this=0x4918a480)
    at /hack/b2g/B2G/objdir-gecko/ipc/ipdl/PCompositorParent.cpp:831
#16 0x41acf8de in mozilla::layers::PCompositorParent::OnChannelError (this=0x4918a480)
    at /hack/b2g/B2G/objdir-gecko/ipc/ipdl/PCompositorParent.cpp:664
#17 0x41a63f08 in mozilla::ipc::AsyncChannel::NotifyMaybeChannelError (this=0x4918a488)
    at /hack/mozilla-central/ipc/glue/AsyncChannel.cpp:570
#18 0x41a651e0 in mozilla::ipc::AsyncChannel::OnNotifyMaybeChannelError (this=0x4918a488)
    at /hack/mozilla-central/ipc/glue/AsyncChannel.cpp:535
#19 0x41a392fc in DispatchToMethod<mozilla::dom::ContentParent, void (mozilla::dom::ContentParent::*)()> (this=<value optimized out>) at /hack/mozilla-central/ipc/chromium/src/base/tuple.h:383
---Type <return> to continue, or q <return> to quit---
#20 RunnableMethod<mozilla::dom::ContentParent, void (mozilla::dom::ContentParent::*)(), Tuple0>::Run (this=<value optimized out>) at /hack/mozilla-central/ipc/chromium/src/base/task.h:307
#21 0x41e6be8e in MessageLoop::RunTask (this=0x47cffdd0, task=0x494de460)
    at /hack/mozilla-central/ipc/chromium/src/base/message_loop.cc:334
#22 0x41e6c6b8 in MessageLoop::DeferOrRunPendingTask (this=0x75, 
    pending_task=<value optimized out>)
    at /hack/mozilla-central/ipc/chromium/src/base/message_loop.cc:342
#23 0x41e6d40e in MessageLoop::DoWork (this=0x47cffdd0)
    at /hack/mozilla-central/ipc/chromium/src/base/message_loop.cc:442
#24 0x41e6d78a in base::MessagePumpDefault::Run (this=0x470fd2a0, delegate=0x47cffdd0)
    at /hack/mozilla-central/ipc/chromium/src/base/message_pump_default.cc:23
#25 0x41e6c442 in MessageLoop::RunInternal (this=0x47cffdd0)
    at /hack/mozilla-central/ipc/chromium/src/base/message_loop.cc:216
#26 0x41e6c4a2 in MessageLoop::RunHandler (this=0x47cffdd0)
    at /hack/mozilla-central/ipc/chromium/src/base/message_loop.cc:209
#27 MessageLoop::Run (this=0x47cffdd0)
    at /hack/mozilla-central/ipc/chromium/src/base/message_loop.cc:183
#28 0x41e763d4 in base::Thread::ThreadMain (this=0x459f0a90)
    at /hack/mozilla-central/ipc/chromium/src/base/thread.cc:156
#29 0x41e83b06 in ThreadFunc (closure=0x75)
    at /hack/mozilla-central/ipc/chromium/src/base/platform_thread_posix.cc:39
#30 0x400f7e18 in __thread_entry (func=0x41e83afd <ThreadFunc>, arg=0x459f0a90, 
    tls=<value optimized out>) at bionic/libc/bionic/pthread.c:217
#31 0x400f796c in pthread_create (thread_out=<value optimized out>, attr=0xbecc1240, 
    start_routine=0x41e83afd <ThreadFunc>, arg=0x459f0a90) at bionic/libc/bionic/pthread.c:357
#32 0x00000000 in ?? ()

Comment 1

[Scoobidiver (away)]

Bug 853960?

Comment 2

[Nick Cameron [:nrc]]

Presumably because we are not calling Disconnect, but I don't know where that is meant to happen or why it is not

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Disconnect during abnormal shutdown

This avoids the assertion.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 742406 [details] [diff] [review]
Disconnect during abnormal shutdown

Nical, does this make sense to you?

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 742406 [details] [diff] [review]
Disconnect during abnormal shutdown

Review of attachment 742406 [details] [diff] [review]:
-----------------------------------------------------------------

It makes sense to me

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f31ae2be12f0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f31ae2be12f0