863410 - [B2G][Music] Ratings bar is not appearing when a song is paused.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Cody Roesch [:croesch]]

Description:
In the Music app, when a song is playing and then the song is paused, the ratings bar is not appearing automatically. This is failing test case 2684 which is linked below.

Steps to Repro:
1. Flash to Inari build: 20130418070206
2. Launch the Music app.
3. Tap on a song to begin playing and notice the ratings bar appears then shortly after will disappear.
4. Tap the pause button to pause the song.
5. Notice that pausing the song does not cause the ratings bar to appear as the testcase has suggested.

Actual Results:
Ratings bar is not appearing when pausing a song.

Expected Results:
The Ratings bar will appear when the pause button is pressed and the song is paused.

Environmental Variables:
Inari Build: 20130418070206
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/0c76ef5f8677
Gaia   64d5096e1746bd4b08bc1bf69844d164ac961970
Kernel:  Feb 21st

Notes:
Repro Rate: 5/5 100%
Link to a failed TC: https://moztrap.mozilla.org/runtests/run/1105/env/316/?pagenumber=1&pagesize=100&sortfield=order&sortdirection=asc&filter-id=2684
UCID: As a user, I can rate a song between 0 and 5 stars so i can keep track of the music that i am interested in.

Comment 1

[Marcia Knous [:marcia]]

I think this is by design - the rating bar appears briefly and then you have to tap on it to get it to appear.

I referenced the original wireframes and it doesn't go into much detail about how the ratings is supposed to work - we would have to hunt down the implementation bug to see what they say in the bug comments.

Comment 2

[Jeni]

Issue no longer repros on 

Unagi Build ID: 20130429070204
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2

Rating bar now is displayed when user pressed pause in the music application.  Rating bar also shows when tapping on screen while music plays.

Comment 3

[Jeni]

Disregard comment 2.  I miss understood expected resolute.  Issue still repros.  When user plays music in the music app user will see the rating bar.  However if user waits until rating bar goes away and then pauses the music the rating bar does not come back up unless user taps on screen.

Comment 4

[Jeni]

Unagi Build ID: 20130429070204
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2

Comment 5

[Jeni]

Issue repros on 
Leo Build ID: 20130610070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ce3b99781d182ad550a325206990c249b0dbcf0e
Platform Version: 18.0

If user waits til rating bar goes away and then pressed pause rating bar does not come back up unless user taps in screen.

Comment 6

[Sarah Parsons]

Attachment: logcat

Comment 7

[Jeni]

Leo Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1 

If user waits til rating bar goes away and then pressed pause rating bar does not come back up unless user taps in screen.  Rating bar is displayed once again when user plays music again.

Comment 8

[John Hammink]

Let's check the implementation bug for this.  We need to see if this is by design nor not.

Comment 10

[Mike Lien[:mlien]]

nom blocking 2.2? to see if this is by design

Comment 11

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

I've made a one-line-fix to show the rating bars. If this is the expected behaviour I think we should display the bars while the song is paused and not hide it after 5 seconds.

Thanks!

Comment 12

[Hubert Figuiere [:hub]]

Manuel,

Thank you for your patch. You should submit it for review to Dominic Kuo [:dkuo] so that we can get this fix landed.

Thanks.

Comment 13

[Hema Koka [:hema]]

Thanks for fixing it. Please put this through review with Dominic Kuo or Jim Porter.

Not blocking release, so removing nom

Comment 14

[Verson Xiong (Leave from Mozilla)]

Attachment: video22.mp4

This issue can be repro on latest build of Flame 2.2 & 3.0 with the same steps in comment 0.
See attachment:logcat_0157.txt & video22.mp4

Reproduction build:
Flame 2.2 (affected)
Build ID               20150414162502
Gaia Revision          16e948bfaaa15dbc0200135d52f16257b4eab193
Gaia Date              2015-04-14 21:08:25
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0eec28e78eb1
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.201515
Firmware Date          Tue Apr 14 20:15:24 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0:(affected)
Build ID               20150414160204
Gaia Revision          8e28588496f82f8f069c171c65842d622b9d8d7d
Gaia Date              2015-04-14 18:43:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/de27ac2ab94f
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.194002
Firmware Date          Tue Apr 14 19:40:12 EDT 2015
Bootloader             L1TC000118D0

Comment 15

[Verson Xiong (Leave from Mozilla)]

Attachment: logcat_0157.txt

Comment 16

[Dominic Kuo [:dkuo]]

Let's have ux people to comment on this first, Jacqueline, do you think music app needs this behaviour?

Comment 17

[Jacqueline Savory [:jsavory] UX]

It does feel odd to me that the ratings bar does not appear when the song is paused. I would recommend to have the expected behaviour of displaying the ratings bar in this case.

Comment 18

[Dominic Kuo [:dkuo]]

Comment on attachment 8545141 [details] [review]
Proposed patch

Thanks Jacqueline, and :mancas's patch looks good to me according to comment 17.

Comment 20

[Verson Xiong (Leave from Mozilla)]

Attachment: logcat_0336.txt

I can reproduce this issue on NGA & OGA music app of FlameKK/AriseKK v2.5 latest build by STR in comment 0.
Actually result: Ratings bar is not appearing when pausing a song.
Reproduce rate: 10/10
See NGA_FlameKK_v2.5.3gp

Device: Flame KK v2.5(Affected)
Build ID               20151007150205
Gaia Revision          b99837aa2294348317bcae68acabe71d9a83d774
Gaia Date              2015-10-07 13:04:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e1fa696e2b626ead6817b7c5bd871fec5d5ab5a
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151007.183338
Firmware Date          Wed Oct  7 18:33:51 EDT 2015
Bootloader             L1TC000118D0

Device: Aries KK v2.5(Affected)
Build ID               20151008002716
Gaia Revision          b99837aa2294348317bcae68acabe71d9a83d774
Gaia Date              2015-10-07 13:04:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c6ede6f30f3dc886543bb1c76fd7c8b5a151786b
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151007.234555
Firmware Date          Wed Oct  7 23:46:03 UTC 2015
Bootloader             s1

Comment 21

[Verson Xiong (Leave from Mozilla)]

Attachment: NGA_FlameKK_v2.5.3gp

Comment 22

[Hema Koka [:hema]]

This is not an issue with NGA only. Not considering for 2.5.

Comment 23

[BMO Automation]

Firefox OS is not being worked on