Closed Bug 863429 Opened 7 years ago Closed 7 years ago

Fix jprof in debug builds

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jesup, Assigned: jesup)

Details

Attachments

(1 file, 2 obsolete files)

Jprof does some unseemly things with malloc and realloc of C++ structure arrays.  Changes to malloc/realloc on debug builds to set memory to 0xa5 broke this broken behavior.

This patch unbreaks the breakage back to it's original working (but broken-in-theory) state.  :-)

(Basically, it assumes it knows that it can init all the vars in the Symbol structures to 0's, which happens to be true).

This is a fairly minimal patch to make it work again (and fix some nasty mis-indentation).
Attachment #739260 - Attachment is obsolete: true
Attachment #739571 - Attachment is obsolete: true
Comment on attachment 739574 [details] [diff] [review]
Fix jprof on debug builds NPOTB DONT BUILD rs=dbaron

rs will be fine... :-)
Attachment #739574 - Flags: review?(dbaron)
Comment on attachment 739574 [details] [diff] [review]
Fix jprof on debug builds NPOTB DONT BUILD rs=dbaron

rubber stamp, then :-)
Attachment #739574 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/931e85b3d576
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.