863462 - Sign in screen doesn't match the mocks

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Payments/Refunds, defect, P4)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Compare the current Sign in screen to the mocks @ https://www.dropbox.com/s/4xznirpujqidwdr/Marketplace_Payments_Flows_Persona_031313.pdf

The following changes need to be made to match the mocks:
a) remove the text-"Sign in to continue with the payment"
b) Add copy-By proceeding, you agree to Persona's Terms and Privacy Policy
c) Increase the font size of "Sign in" in the header as well as the button.

Comment 1

[[e-mail]]

r? https://github.com/mozilla/webpay/pull/97

Comment 2

[[e-mail]]

There's actually a UX issue with this that I've just found doing some testing on device prior to landing this change.

The problem is that links with target="_blank" don't work at all. If you remove that the links simply go to the url specified which doesn't look too great in the cramped space of the trusted UI.

On persona itself they handle this nicely with overlays that have the privacy policy so the question is do we need to duplicate persona's terms in webpay (not ideal because we'd need to keep them in-sync) or can we leave it to webpay to display the terms and conditions which it does when you get there?

Comment 3

[Maureen Hanratty]

Stuart - would you mind posting a screenshot of the Persona overlays so I can see what they look like?

Is it possible to take the user to the browser to view the terms and conditions for the Marketplace? I think that is what you are asking in you last sentence but I wasn't sure.

Comment 4

[[e-mail]]

Attachment: Screenshot of persona's terms via persona.

See attached screenshot of persona's terms shown in an overlay.

Comment 5

[Maureen Hanratty]

Thanks Stuart. Shane on Persona actually changed the design a bit, re-purposing the error message screen to show the TOS. You can see a screenshot of it below:

https://www.dropbox.com/sh/weyhv4bgyiy3syu/ueyovBCd3O#f:terms%20of%20service.png

I'm not 100% satisfied with it but I think I'm ok with it for launch. Apparently there are technical issues with opening it up in the browser?

Comment 6

[[e-mail]]

Maureen: that link to the screenshot appears to be dead.

To clarify once bug 872648 is fixed (This will make the terms and privacy links work in the persona page) will we need any changes to the webpay sign-in page or can this bug be closed?

Comment 7

[Maureen Hanratty]

What does the webpay sign-in page look like? Can you post a screenshot of it so I know what screen(s) you are talking about? Thanks!

Comment 8

[[e-mail]]

The screen that we currently have is as per the screenshot in the comment 1.

Comment 9

[[e-mail]]

Sorry, that should be as per the bug description.

Comment 10

[Maureen Hanratty]

Do we need to have the Terms & Conditions and Privacy on the Marketplace screen if it is presented on the Persona sign in screen?

Comment 11

[[e-mail]]

(In reply to Maureen Hanratty from comment #10)
> Do we need to have the Terms & Conditions and Privacy on the Marketplace
> screen if it is presented on the Persona sign in screen?

Yep, that's the question I'm looking to get an answer to. Given we can't currently open links outside of the trusted-ui from the marketplace sign-in screen.

Comment 12

[Maureen Hanratty]

I think we do not need to show it since it is shown on the Persona sign-in screen (https://github.com/mozilla/browserid/issues/3410#issuecomment-18603204).

Comment 13

[[e-mail]]

Thanks Maureen, so are you happy to close this bug leaving the sign-in page as is?

Comment 14

[Maureen Hanratty]

Yes, let's close it :)

Comment 15

[David Bialer [:dbialer]]

Hi - Persona terms of use are different than Marketplace Terms of Use.  Same with privacy.  I haven't followed this bug in detail.  But we should ensure we don't confuse these, and as they are legal documents, we make sure that the user has an opportunity to agree to them.

Comment 16

[[e-mail]]

David: If you're not already signed to persona then the persona login screen says:

By proceeding, you agree to Persona's [Terms] and [Privacy Policy]

You also agree to marketplace-dev.allizom.org's [Terms] and [Privacy Policy]

These are not shown if persona knows your email address - I'm not sure if that's expected, if not that's a persona issue.