Change error message when running "profiler close" (GCLI command) when profiler is not open

RESOLVED FIXED in Firefox 24

Status

enhancement
P2
normal
RESOLVED FIXED
6 years ago
Last year

People

(Reporter: mihaelav, Assigned: anton)

Tracking

Trunk
Firefox 24
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox22 affected, firefox23 affected)

Details

Attachments

(1 attachment)

Affected branches:
Latest Nightly: Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20130417 Firefox/23.0
Latest Aurora: 
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130418 Firefox/22.0, build ID: 20130418004017
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20130418 Firefox/22.0, build ID: 20130418004017
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20130418 Firefox/22.0, build ID: 20130418004017

Steps to reproduce:
1. Open Developer Toolbar (SHIFT + F2)
2. Type "profiler close" in GCLI

Actual result: "TypeError: gDevTools.closeToolbox(...) is undefined" message is displayed

Expected result: Error message should say that Profiler is not open
Seems like an oversight on my part in the original implementation.
Assignee: nobody → anton
Status: NEW → ASSIGNED
Attachment #764501 - Flags: review?(jwalker)
Attachment #764501 - Flags: review?(dcamp)
Comment on attachment 764501 [details] [diff] [review]
Make 'profiler close' do nothing when toolbox is closed

Review of attachment 764501 [details] [diff] [review]:
-----------------------------------------------------------------

I think my r+ can do for dcamp too.
Attachment #764501 - Flags: review?(jwalker) → review+
https://hg.mozilla.org/mozilla-central/rev/f4c0eab43adf
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Attachment #764501 - Flags: review?(dcamp)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.