863660 - SimplePush: Make push enable/disable restartless

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Not a immediate requirement for b2g 1.1, but would be nice to have in the version after that.

Disabling push or enabling it requires a device restart after toggling the preference.
settings or shell.js could monitor the services.push.enabled pref.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

On further thought, it makes more sense to have 'enable/disable' for the user mean whether the network connection is active or not. The push service will always be loaded even if push is disabled in the UX.

Patch coming up.

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Toggle connection based on pref.

pref is services.push.connection.enabled.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 752994 [details] [diff] [review]
Toggle connection based on pref.

Review of attachment 752994 [details] [diff] [review]:
-----------------------------------------------------------------

Dumb question - Why do we want the push service to be loaded even if push is disabled?

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 752994 [details] [diff] [review]
Toggle connection based on pref.

Review of attachment 752994 [details] [diff] [review]:
-----------------------------------------------------------------

Dumb question - Why do we want the push service to be loaded even if push is disabled?  r- until I get an answer.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

I think local operations like registrations() and unregister() should still succeed.
This pref is for the user's point of view. That is, conserve battery life by keeping connections and alarms shut. The logic to watch the pref could be moved out into the component in bug 871372, but do we really need the optimization until PushService is causing problems by just being enabled.

That said Push.js should also be checking the connection pref and error the register() call immediately.

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Toggle connection based on pref.

Add immediate NetworkError to push.register()

Comment 7

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

http://hg.mozilla.org/projects/birch/rev/c55b4e2fa1be

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c55b4e2fa1be

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Just a note that patches in bug 857464 will rename services.push.connection.enabled to services.push.userEnabled instead.