Stop converting dates to strings in ContactManager

RESOLVED FIXED

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: reuben, Assigned: reuben)

Tracking

18 Branch
Points:
---

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 739511 [details] [diff] [review]
Stop comparing dates with strings

This popped up in the profiles and it's an easy win. Fixed in central, this is b2g18 only.
Attachment #739511 - Flags: review?(anygregor)
(Assignee)

Updated

5 years ago
blocking-b2g: --- → tef?
(Assignee)

Updated

5 years ago
Attachment #739511 - Flags: review?(anygregor) → review?(justin.lebar+bug)
(Assignee)

Updated

5 years ago
Attachment #739511 - Flags: review?(justin.lebar+bug) → review?(bent.mozilla)
Comment on attachment 739511 [details] [diff] [review]
Stop comparing dates with strings

Review of attachment 739511 [details] [diff] [review]:
-----------------------------------------------------------------

r=me!
Attachment #739511 - Flags: review?(bent.mozilla) → review+
Comment on attachment 739511 [details] [diff] [review]
Stop comparing dates with strings

[Triage Comment]
bent says this is hurting performance, and it's an obviously virtuous fix.
Attachment #739511 - Flags: approval-mozilla-b2g18+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/releases/mozilla-b2g18/rev/09470bb4b4a7
Status: NEW → RESOLVED
blocking-b2g: tef? → ---
Last Resolved: 5 years ago
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
Resolution: --- → FIXED
(Assignee)

Comment 4

5 years ago
I didn't mean to clear the blocking request.
blocking-b2g: --- → tef?
blocking-b2g: tef? → tef+

Comment 5

5 years ago
Probably hasn't been uplifted because of the wontfix status. Fixing.
status-b2g18-v1.0.1: wontfix → affected
Keywords: checkin-needed
(Assignee)

Comment 6

5 years ago
Fixed by https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/0da545a83edd
status-b2g18-v1.0.1: affected → fixed
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.