Closed Bug 863672 Opened 7 years ago Closed 6 years ago
.in changes to comm-aurora
We need to port a few changes from mozilla-aurora configure to configure.in one last time (basically, Bug 846540 fixed most cases where configure.in changes had to be ported). Basically SeaMonkey needs the MOZ_GAMEPAD and the MOZ_WEBSPEECH changes from Bug Bug 604039 and 650295 to fix quite a few tests (maybe this bug should go to the SeaMonkey product). See http://hg.mozilla.org/mozilla-central/annotate/f8d27fe5d7c0//configure.in#l5921 for MOZ_GAMEPAD and http://hg.mozilla.org/mozilla-central/annotate/f8d27fe5d7c0//configure.in#l5354 for MOZ_WEBSPEECH.
This seems to fix the issue (it's still building, I'm not really a configure.in expert :)
Forgot to hg qrefresh
Attachment #739548 - Attachment is obsolete: true
Thunderbird comm-aurora Try build worked fine (build only, no tests)
Comment on attachment 739549 [details] [diff] [review] Patch This patch copies over the required changes from mozilla/configure.in. I only changed this line AC_CHECK_HEADERS([linux/joystick.h]) from MOZ_CHECK_HEADER([linux/joystick.h]) (comm-* does not know the MOZ_CHECK_HEADERS macro) Note: This is a comm-aurora patch, comm-central does not need this patch (anymore)
Attachment #739549 - Flags: review?(bugspam.Callek)
I meant: "(comm-* does not know the MOZ_CHECK_HEADER macro)" (without the S)
Comment on attachment 739549 [details] [diff] [review] Patch This patch is needed for comm-aurora only, comm-central does not need this (anymore).
Attachment #739549 - Flags: review?(bugspam.Callek) → review?(Pidgeot18)
Comment on attachment 739549 [details] [diff] [review] Patch Review of attachment 739549 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +4404,5 @@ > + MOZ_WEBSPEECH=, > + MOZ_WEBSPEECH=1) > + > +if test -n "$MOZ_WEBSPEECH"; then > + AC_DEFINE(MOZ_WEBSPEECH) It looks like in mozilla-aurora, MOZ_WEBSPEECH also implies MOZ_MEDIA.
Attachment #739549 - Flags: review?(Pidgeot18) → review+
Comment on attachment 739549 [details] [diff] [review] Patch [Approval Request Comment] Regression caused by (bug #): - User impact if declined: SeaMonkey browser tests fail, maybe also has unknown user impact (not known if there are bugs that are caused by this) Testing completed (on c-c, etc.): Patch cannot be tested on comm-central as it applies to comm-aurora only Risk to taking this patch (and alternatives if risky): Few risk I would say, the variables enabled/disabled by this patch get only used in the comm-central build system. Whether or not the core code in mozilla/ (which those configure vars apply to) gets built is "decided" by mozilla/configure.in and not by the comm-central configure.in. The configure changes here are only needed to fix the installer package manifest (because the manifest uses ifdefs).
Attachment #739549 - Flags: approval-comm-aurora?
Attachment #739549 - Flags: approval-comm-aurora? → approval-comm-aurora+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 22.0
You need to log in before you can comment on or make changes to this bug.