Closed
Bug 863748
Opened 9 years ago
Closed 9 years ago
Add selection tests for sub frame form inputs
Categories
(Firefox for Metro Graveyard :: Input, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(3 files, 2 obsolete files)
10.79 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
12.93 KB,
patch
|
rsilveira
:
review+
|
Details | Diff | Splinter Review |
7.98 KB,
patch
|
rsilveira
:
review+
|
Details | Diff | Splinter Review |
No description provided.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Moving some stuff down in the res subfolder.
Assignee: nobody → jmathies
![]() |
Assignee | |
Updated•9 years ago
|
Attachment #740398 -
Attachment is obsolete: true
![]() |
Assignee | |
Updated•9 years ago
|
Attachment #740398 -
Attachment is obsolete: false
![]() |
Assignee | |
Comment 2•9 years ago
|
||
Basic selection in a textarea inside a sub frame. Includes a test for bug 862054.
![]() |
Assignee | |
Comment 3•9 years ago
|
||
Really simple change, no functionality added. I've moved a couple html files down into ./res and I'm disable plugin tests for now.
Attachment #740398 -
Attachment is obsolete: true
Attachment #740401 -
Attachment is obsolete: true
Attachment #740467 -
Flags: review?(mbrubeck)
![]() |
Assignee | |
Comment 4•9 years ago
|
||
![]() |
Assignee | |
Comment 5•9 years ago
|
||
These depend on the parent bug, so I'll wait until that lands.
Updated•9 years ago
|
Attachment #740467 -
Flags: review?(mbrubeck) → review+
![]() |
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 740473 [details] [diff] [review] textarea subframe tests These depend on a batch of patches I'll be landing on inbound this morning. If you want to take them for a spin put off reviewing until the parent bug closes out.
Attachment #740473 -
Flags: review?(rsilveira)
![]() |
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 740474 [details] [diff] [review] input subframe test I think this last one officially uses up my rsilveira test review quota for this iteration. ;) I've been trying to avoid bothering matt since he's been overloaded with reviews as of late.)
Attachment #740474 -
Flags: review?(rsilveira)
Comment 8•9 years ago
|
||
Comment on attachment 740473 [details] [diff] [review] textarea subframe tests Review of attachment 740473 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me!
Attachment #740473 -
Flags: review?(rsilveira) → review+
Comment 9•9 years ago
|
||
Comment on attachment 740474 [details] [diff] [review] input subframe test Review of attachment 740474 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #740474 -
Flags: review?(rsilveira) → review+
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4dab39869e57 https://hg.mozilla.org/mozilla-central/rev/d51a9c4ebf3a https://hg.mozilla.org/mozilla-central/rev/295b11e2ee6f
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Updated•8 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•