Closed Bug 863748 Opened 7 years ago Closed 7 years ago

Add selection tests for sub frame form inputs

Categories

(Firefox for Metro Graveyard :: Input, defect)

Product:
Firefox for Metro Graveyard
Component:
Input
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(3 files, 2 obsolete files)

moving files and disable plugin tests
10.79 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review
textarea subframe tests
12.93 KB, patch
rsilveira
: review+
Details | Diff | Splinter Review
input subframe test
7.98 KB, patch
rsilveira
: review+
Details | Diff | Splinter Review 
No description provided.
Depends on: 862054
Attached patch reorg (obsolete) — — Splinter Review 
Moving some stuff down in the res subfolder.
Assignee: nobody → jmathies
Attachment #740398 - Attachment is obsolete: true
Attachment #740398 - Attachment is obsolete: false
Attached patch textarea tests (obsolete) — — Splinter Review 
Basic selection in a textarea inside a sub frame. Includes a test for bug 862054.
Really simple change, no functionality added. I've moved a couple html files down into ./res and I'm disable plugin tests for now.
Attachment #740398 - Attachment is obsolete: true
Attachment #740401 - Attachment is obsolete: true
Attachment #740467 - Flags: review?(mbrubeck)
These depend on the parent bug, so I'll wait until that lands.
Attachment #740467 - Flags: review?(mbrubeck) → review+
Comment on attachment 740473 [details] [diff] [review]
textarea subframe tests

These depend on a batch of patches I'll be landing on inbound this morning. If you want to take them for a spin put off reviewing until the parent bug closes out.
Attachment #740473 - Flags: review?(rsilveira)
Comment on attachment 740474 [details] [diff] [review]
input subframe test

I think this last one officially uses up my rsilveira test review quota for this iteration. ;) I've been trying to avoid bothering matt since he's been overloaded with reviews as of late.)
Attachment #740474 - Flags: review?(rsilveira)
Comment on attachment 740473 [details] [diff] [review]
textarea subframe tests

Review of attachment 740473 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!
Attachment #740473 - Flags: review?(rsilveira) → review+
Comment on attachment 740474 [details] [diff] [review]
input subframe test

Review of attachment 740474 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #740474 - Flags: review?(rsilveira) → review+
https://hg.mozilla.org/mozilla-central/rev/4dab39869e57
https://hg.mozilla.org/mozilla-central/rev/d51a9c4ebf3a
https://hg.mozilla.org/mozilla-central/rev/295b11e2ee6f
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.