863749 - Create API for checking if a display name or subdomain is free

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Kieran Sedgwick (:sedge)]

To enhance the UX, there should be a Login API call that checks if a passed displayName or subdomain is free to be registered.

Comment 1

[David Humphrey (:humph)]

See also bug 863362

Comment 2

[David Humphrey (:humph)]

This likely wants to be done for internal use by our node apps, but not exposed externally.  Following the same pattern cade has done with MakeAPI (e.g., using basic authentication on the route) should be enough.

I suggest:

GET http://login.webmaker.org/user/subdomain/:name

returns 1 of 3 things:

404 (Not Found) - subdomain given in `:name` is available (i.e., wasn't found/taken)
406 (Not Acceptable) - subdomain given in `:name` is blacklisted (i.e., we won't accept it)
200 (OK) - subdomain given in `:name` is good and being used (i.e., someone has already taken it)

Comment 3

[David Humphrey (:humph)]

I'm probably going to get one of my new guys to try this as a first bug, I'll assign later today.

Comment 4

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/54

Comment 5

[Kieran Sedgwick (:sedge)]

Comment on attachment 749287 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/54

A few changes required, and a question that needs to be resolved but other than that it looks good!  Check the PR for notes, and flag for review again when you're done.

Comment 6

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/54

Comment 7

[David Humphrey (:humph)]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/54

Comment 8

[Ali Al Dallal [:alicoding]]

Comment on attachment 749308 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/54

Change the order of the check cases and reformat the code.

Comment 9

[David Humphrey (:humph)]

One comment in PR, fix that and this is r+ from me.  Let sedge look at it again.

Comment 10

[Ali Al Dallal [:alicoding]]

Comment on attachment 749308 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/54

Removed the unnecessary code from the error case and removed some blank line

Comment 11

[Ali Al Dallal [:alicoding]]

Comment on attachment 749308 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/54

Changed the variable name of the return value to 'name'

Comment 12

[Kieran Sedgwick (:sedge)]

Comment on attachment 749308 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/54

Hey Ali, looking good.  Remember though, the fewer commits the better (and ideally just one per bug) so r+ if you rebase.

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/cc0cbe7f4629d42eeeda23e10eafe82134f4de9e
Fixes Bug 863749 - Create API for checking if a subdomain is free r=humph,sedge