863850 - Should have option to launch application on android even if application already started

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

To fix bug 860790, we're going to need this ability. Let's at this to mozdevice.

Comment 1

[William Lachance (:wlach)]

Attachment: Add option to still launch fennec/android apps even if already running

Since we were discussing this on irc a few days ago, figured :bc would be a logical person to review.

Comment 2

[Bob Clary [:bc] (inactive)]

Comment on attachment 739770 [details] [diff] [review]
Add option to still launch fennec/android apps even if already running

Review of attachment 739770 [details] [diff] [review]:
-----------------------------------------------------------------

I think I understand the argument parsing. ;-) Interesting. r+ with the indentation nit.

::: mozdevice/mozdevice/dmcli.py
@@ +115,1 @@
>                                              'help': 'launch fennec'

indentation.

Comment 3

[Bob Clary [:bc] (inactive)]

Comment on attachment 739770 [details] [diff] [review]
Add option to still launch fennec/android apps even if already running

Review of attachment 739770 [details] [diff] [review]:
-----------------------------------------------------------------

I think I understand the argument parsing. ;-) Interesting. r+ with the indentation nit.

::: mozdevice/mozdevice/dmcli.py
@@ +110,5 @@
> +                                                      { 'name': '--mozenv', 'action': 'store' },
> +                                                      { 'name': '--no-fail-if-running',
> +                                                        'action': 'store_true',
> +                                                        'help': 'Don\'t fail if application is already running' }
> + ],

the remark about indentation was about this line where ], needs to be indented.

@@ +115,1 @@
>                                              'help': 'launch fennec'

indentation.

Comment 4

[William Lachance (:wlach)]

Pushed (with indentation fix): https://github.com/mozilla/mozbase/commit/42b72fc7d6933a8c62afed37350aa5f7aa137cfe