Closed
Bug 863850
Opened 12 years ago
Closed 12 years ago
Should have option to launch application on android even if application already started
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
|
11.86 KB,
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
To fix bug 860790, we're going to need this ability. Let's at this to mozdevice.
|
Assignee | |
Comment 1•12 years ago
|
||
Since we were discussing this on irc a few days ago, figured :bc would be a logical person to review.
Attachment #739770 -
Flags: review?(bclary)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 739770 [details] [diff] [review]
Add option to still launch fennec/android apps even if already running
Review of attachment 739770 [details] [diff] [review]:
-----------------------------------------------------------------
I think I understand the argument parsing. ;-) Interesting. r+ with the indentation nit.
::: mozdevice/mozdevice/dmcli.py
@@ +115,1 @@
> 'help': 'launch fennec'
indentation.
Attachment #739770 -
Flags: review?(bclary) → review+
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 739770 [details] [diff] [review]
Add option to still launch fennec/android apps even if already running
Review of attachment 739770 [details] [diff] [review]:
-----------------------------------------------------------------
I think I understand the argument parsing. ;-) Interesting. r+ with the indentation nit.
::: mozdevice/mozdevice/dmcli.py
@@ +110,5 @@
> + { 'name': '--mozenv', 'action': 'store' },
> + { 'name': '--no-fail-if-running',
> + 'action': 'store_true',
> + 'help': 'Don\'t fail if application is already running' }
> + ],
the remark about indentation was about this line where ], needs to be indented.
@@ +115,1 @@
> 'help': 'launch fennec'
indentation.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Pushed (with indentation fix): https://github.com/mozilla/mozbase/commit/42b72fc7d6933a8c62afed37350aa5f7aa137cfe
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•