Should have option to launch application on android even if application already started

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

To fix bug 860790, we're going to need this ability. Let's at this to mozdevice.
Created attachment 739770 [details] [diff] [review]
Add option to still launch fennec/android apps even if already running

Since we were discussing this on irc a few days ago, figured :bc would be a logical person to review.
Attachment #739770 - Flags: review?(bclary)

Comment 2

6 years ago
Comment on attachment 739770 [details] [diff] [review]
Add option to still launch fennec/android apps even if already running

Review of attachment 739770 [details] [diff] [review]:
-----------------------------------------------------------------

I think I understand the argument parsing. ;-) Interesting. r+ with the indentation nit.

::: mozdevice/mozdevice/dmcli.py
@@ +115,1 @@
>                                              'help': 'launch fennec'

indentation.
Attachment #739770 - Flags: review?(bclary) → review+

Comment 3

6 years ago
Comment on attachment 739770 [details] [diff] [review]
Add option to still launch fennec/android apps even if already running

Review of attachment 739770 [details] [diff] [review]:
-----------------------------------------------------------------

I think I understand the argument parsing. ;-) Interesting. r+ with the indentation nit.

::: mozdevice/mozdevice/dmcli.py
@@ +110,5 @@
> +                                                      { 'name': '--mozenv', 'action': 'store' },
> +                                                      { 'name': '--no-fail-if-running',
> +                                                        'action': 'store_true',
> +                                                        'help': 'Don\'t fail if application is already running' }
> + ],

the remark about indentation was about this line where ], needs to be indented.

@@ +115,1 @@
>                                              'help': 'launch fennec'

indentation.
Pushed (with indentation fix): https://github.com/mozilla/mozbase/commit/42b72fc7d6933a8c62afed37350aa5f7aa137cfe
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.