If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Allow initial heap placement from more places

RESOLVED FIXED in mozilla23

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 739776 [details] [diff] [review]
v0

Brian found many places in Bug 851057 where we were not passing through the initial heap correctly to the underlying object creation routines.
Attachment #739776 - Flags: review?(wmccloskey)
Attachment #739776 - Flags: review?(terrence)
Attachment #739776 - Flags: feedback?(bhackett1024)
(Assignee)

Updated

5 years ago
Attachment #739776 - Flags: review?(terrence) → review+
Comment on attachment 739776 [details] [diff] [review]
v0

Review of attachment 739776 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know enough to review this code. Please ask dvander if you want additional review.
Attachment #739776 - Flags: review?(wmccloskey)
(Assignee)

Comment 2

5 years ago
Created attachment 744328 [details] [diff] [review]
v1: removed the string bits, which got checked in elsewhere.

The changes here are straightforward, I'd just like a quick sanity check on the changes to our initial heap placement when running in JIT code.
Attachment #739776 - Attachment is obsolete: true
Attachment #739776 - Flags: feedback?(bhackett1024)
Attachment #744328 - Flags: review?(dvander)
Attachment #744328 - Flags: review?(dvander) → review+
(Assignee)

Comment 3

5 years ago
Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=15f0148eef12

Pushed at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/776c624e358c
https://hg.mozilla.org/mozilla-central/rev/776c624e358c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.