863873 - Wire popcorn maker's publish up to make API

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

Similar to bug 861816, we need to plug popcorn maker into the make api.

This mean search, create, update and delete to the make API.

We'll need to use search for displaying personal projects.

We'll need to use create and update when we publish a popcorn project.

Delete needs to be wired up to the project dashboard like search.

Comment 1

[Matthew Schranz [:mjschranz]]

Going to be working on this for the week.

Comment 2

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/butter/pull/1681

Initial bit of wiring MakeAPI into Popcorn Maker. At this point it's present for creation, updating and deletion.

Comment 3

[Jon Buckley]

Comment on attachment 748017 [details] [review]
https://github.com/mozilla/butter/pull/1681

r+

Comment 4

[Jon Buckley]

Did you want to merge this into butter, or the new popcorn.webmaker.org repo?

Comment 5

[Matthew Schranz [:mjschranz]]

I think we want to hold off on this one. The MakeAPI is fairly specific to webmaker IMO and think it shouldn't be apart of butter.

Comment 6

[David Humphrey (:humph)]

Comment on attachment 748017 [details] [review]
https://github.com/mozilla/butter/pull/1681

See notes in PR.  I agree to not land this in butter, and also to strip out some of the demo aspects before we do.  The general shape of the patch is good, though.  Nice work.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Adding dependency as per comment 5; ideally mjscrhanz and jbuck can co-ordinate so that all happens today? Pretty please?

Comment 8

[Matthew Schranz [:mjschranz]]

The thing is, there are other aspects we have to consider.

We can just turn this on in dev with a MakeAPI endpoint that everyone will point to. If we do, there will be conflicts when adding projects to the MakeAPI because URLs are set as unique.

Do we force everyone to run a local instance of the makeapi while testing popcorn maker? That seems really annoying.

Do we turn the MakeAPI off for Dev? Not annoying, but then we don't catch potential errors until we hit production.

This patch isn't ready yet for landing, review nits aside.

Comment 9

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/3

New repo, new pull request.

Comment 10

[Matthew Schranz [:mjschranz]]

This is received updates for recent API changes.

Comment 11

[Matthew Schranz [:mjschranz]]

Comment on attachment 748863 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/3

Blocked on 873470 for now, but this works otherwise.

Comment 12

[Chris DeCairos (:cade)]

Comment on attachment 748863 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/3

r+ with a fix for one issue (see pull request)

Comment 13

[Matthew Schranz [:mjschranz]]

There's one basic thing preventing this from working. At this point, if I sign in with my persona account ( [e-mail] ), It's failing on our isAdmin check because I don't have a webmaker account tied to this. We need a way for out Fogin stuff to circumvent this.

Comment 14

[Chris DeCairos (:cade)]

I'd like to see this and Bug 871700 become priority next week in what little time we'll have to work.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

This is definitely a priority for this week; jbuck, pomax, can you help mjschranz with comment 15 and then get this and bug 871700 landed post haste?

Comment 16

[Matthew Schranz [:mjschranz]]

Comment on attachment 748863 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/3

Updated and all working well with the changes humphd has been making for Webfaker.

We need to file a bug at this point to remove the git commit used for the package.json, but otherwise in person R+ from :humph

Comment 17

[Jon Buckley [:jbuck]]

Comment on attachment 748863 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/3

r-, things noted in the pull request mostly related to environment variables.

Comment 18

[Matthew Schranz [:mjschranz]]

Comment on attachment 748863 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/3

Review fixes in.

Comment 19

[Jon Buckley [:jbuck]]

Comment on attachment 748863 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/3

r+ with nits noted in the pull request

Comment 20

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/8b19cb2d8f3ec10ccc85882a7b7a80decca8404d
Fix Bug 863873 - Wire up Popcorn Maker to send project data to the MakeAPI. Use Webfaker for dev environment