863877 - [B2G] [Leo] [Homescreen] Icon Apps don't align properly after moving them around.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Jeni]

Description:
App icons don't aline properly when moving them around rapidly.  Some icons overlap other icons in Doc and the Grid.

Repro Steps:
1) Updated to Leo Build ID: 20130411070205
2) Tap and hold on Icon
3) Move Icon back and forth in a fast motion for a couple minutes
4) Let go of Icon
5) View what happens
6) Repeat if Necessary

Actual:
Icons overlap each other and do not aline properly after moving around.  

Expected:
Icons return to location user started at or move to new requested location.

Environmental  Variables:
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473
Gaia: e7e338a765e22334b40ced41489a785941382c66

Notes:
Repro frequency: 75%
See logcat and screenshots for more info.

Comment 1

[Jeni]

Attachment: Leo Device issue

Comment 2

[Jeni]

Attachment: Leo Device issue 2

Comment 3

[Jeni]

Attachment: Leo Device issue 3

Comment 4

[Jeni]

Attachment: Leo Device issue 4

Comment 5

[Jeni]

Attachment: Leo Device issue 5

Comment 6

[Jeni]

Attachment: Logcat showing issue

Comment 7

[Jeni]

Attachment: Leo Device issue 6

Comment 8

[Cristian Rodriguez (:crdlc)]

please, could you record a video? thanks a lot

Comment 9

[Jeni]

Attachment: Video of Leo Device issue

Comment 10

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

I cannot reproduce the problem but you could test it patch in order to know if it helps

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I was able to produce an old behavior in 2013042507024 build for unagi and in 20130411070205 for leo.

1) if you tap hold an icon
2) then drag that icon near the dock without letting go
3) and then drag to the next page and then let go

The leo device will snap the icon back to the previous page

Both unagi + leo will have a space in the dock where you can't scroll to get to the browser icon.

Still working on looking at the patch... Some reason my gaia wouldn't compile due to conflicts.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Found out that you had to adb root and remount the device before running the |MOZILLA_OFFICIAL=1 make production| command.

I can still reproduce the issue with the patch.

Comment 13

[Cristian Rodriguez (:crdlc)]

Sorry a lot for my bad understanding of the issue. Could you attach a video with all STR? If I would reproduce it on Unagi, I am sure that I could fix

Thanks

Comment 14

[Cristian Rodriguez (:crdlc)]

Are you talking about bug 856863?

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Sorry, I am not talking about bug 856863.  It's an edge case where you slip the icon into the dock and then go to the next page and then let go in one motion.

https://www.youtube.com/watch?v=Rj7dEYnuf3o

Comment 16

[Cristian Rodriguez (:crdlc)]

Good video!! Taking this, thanks

Comment 17

[Cristian Rodriguez (:crdlc)]

I reproduced the problem on master and v1-train but the bug is not reproducible on v1.0.1

Comment 18

[Wayne Chang [:wchang]]

Triage 4/29 - leo+ as bad user experience and relatively high occurrence rate as reported.

Comment 19

[Wayne Chang [:wchang]]

Per comment 17 mark as regression.

Comment 20

[Jason Smith [:jsmith]]

Comment on attachment 741734 [details] [diff] [review]
Patch v1

Our contractors aren't really good candidates for one-off patch testing. If you need someone to test, ping someone in house for support. Sounds like you've confirmed the issue now, though.

Comment 21

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v2

Comment 22

[Jason Smith [:jsmith]]

If we've already got a patch here to fix this, then no need to get to a regression window here.

Comment 23

[Cristian Rodriguez (:crdlc)]

Comment on attachment 743503 [details]
Patch v2

Please, Fran, could you take a look to this one during the week? Thanks a lot

Comment 24

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/e85ec35bc2f06cc84589707ac52ea90675f18247

Comment 25

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e85ec35bc2f06cc84589707ac52ea90675f18247 to:
v1-train: d8536f7484c11fce9f0002900356be35e64421a9

Comment 26

[William Hsu [:whsu]]

This is a duplicated case of Bug 878422

Comment 27

[William Hsu [:whsu]]

Adding a test case.
- https://moztrap.mozilla.org/manage/case/8465/

Comment 28

[Jason Smith [:jsmith]]

That should be a + if you confirmed adding a test case or confirmed there's already coverage. - is only used if the bug doesn't make sense to have test cases for.