The CSP logging from bug 821877 should go to the new Security Pane in the Web Console

RESOLVED FIXED in mozilla23

Status

()

defect
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: grobinson, Assigned: grobinson)

Tracking

Trunk
mozilla23
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 821877 logged errors about invalid CSP errors, which are relevant to web developers, to the web console, but reused the JS filter pane to do so because there was nowhere else to put it. Now that we have a new dedicated security pane introduced in bug 837351, we should log these errors there instead (indeed this was one of the original motivations for creating the dedicated pane).
Assignee: nobody → grobinson
Depends on: 821877, 837351
Posted patch Patch 1Splinter Review
This patch categorizes all nsIScriptErrors with category "CSP" as security errors in the Web Console. I updated the unit test to more precisely test the desired behavior. I also removed the separate calls to ReportToConsole for the CSP errors that are added to the error queue, since doing this caused the errors to be reported to the Error Console twice.
Attachment #739853 - Flags: review?(ddahl)
Attachment #739853 - Flags: review?(bzbarsky)
Comment on attachment 739853 [details] [diff] [review]
Patch 1

r=me
Attachment #739853 - Flags: review?(bzbarsky) → review+
Comment on attachment 739853 [details] [diff] [review]
Patch 1

Review of attachment 739853 [details] [diff] [review]:
-----------------------------------------------------------------

<Just reviewing webconsole.js + tests>

Looks good. How does try server look?
Attachment #739853 - Flags: review?(ddahl) → review+
Try run was green.
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2f839f4b2f32
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.