Closed
Bug 863878
Opened 8 years ago
Closed 8 years ago
The CSP logging from bug 821877 should go to the new Security Pane in the Web Console
Categories
(Core :: Security, defect)
Core
Security
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: grobinson, Assigned: grobinson)
References
Details
Attachments
(1 file)
11.31 KB,
patch
|
ddahl
:
review+
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Bug 821877 logged errors about invalid CSP errors, which are relevant to web developers, to the web console, but reused the JS filter pane to do so because there was nowhere else to put it. Now that we have a new dedicated security pane introduced in bug 837351, we should log these errors there instead (indeed this was one of the original motivations for creating the dedicated pane).
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
This patch categorizes all nsIScriptErrors with category "CSP" as security errors in the Web Console. I updated the unit test to more precisely test the desired behavior. I also removed the separate calls to ReportToConsole for the CSP errors that are added to the error queue, since doing this caused the errors to be reported to the Error Console twice.
Attachment #739853 -
Flags: review?(ddahl)
Attachment #739853 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•8 years ago
|
||
Comment on attachment 739853 [details] [diff] [review] Patch 1 r=me
Attachment #739853 -
Flags: review?(bzbarsky) → review+
Comment 3•8 years ago
|
||
Comment on attachment 739853 [details] [diff] [review] Patch 1 Review of attachment 739853 [details] [diff] [review]: ----------------------------------------------------------------- <Just reviewing webconsole.js + tests> Looks good. How does try server look?
Attachment #739853 -
Flags: review?(ddahl) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=1a29311aa80f
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f839f4b2f32
Flags: in-testsuite+
Keywords: checkin-needed
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2f839f4b2f32
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•