Last Comment Bug 863878 - The CSP logging from bug 821877 should go to the new Security Pane in the Web Console
: The CSP logging from bug 821877 should go to the new Security Pane in the Web...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla23
Assigned To: Garrett Robinson [:grobinson]
:
Mentors:
Depends on: 821877 837351
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-19 14:16 PDT by Garrett Robinson [:grobinson]
Modified: 2013-04-24 05:22 PDT (History)
2 users (show)
garrett.f.robinson+mozilla: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch 1 (11.31 KB, patch)
2013-04-19 15:22 PDT, Garrett Robinson [:grobinson]
bugzilla: review+
bzbarsky: review+
Details | Diff | Review

Description Garrett Robinson [:grobinson] 2013-04-19 14:16:07 PDT
Bug 821877 logged errors about invalid CSP errors, which are relevant to web developers, to the web console, but reused the JS filter pane to do so because there was nowhere else to put it. Now that we have a new dedicated security pane introduced in bug 837351, we should log these errors there instead (indeed this was one of the original motivations for creating the dedicated pane).
Comment 1 Garrett Robinson [:grobinson] 2013-04-19 15:22:07 PDT
Created attachment 739853 [details] [diff] [review]
Patch 1

This patch categorizes all nsIScriptErrors with category "CSP" as security errors in the Web Console. I updated the unit test to more precisely test the desired behavior. I also removed the separate calls to ReportToConsole for the CSP errors that are added to the error queue, since doing this caused the errors to be reported to the Error Console twice.
Comment 2 Boris Zbarsky [:bz] 2013-04-19 21:12:56 PDT
Comment on attachment 739853 [details] [diff] [review]
Patch 1

r=me
Comment 3 David Dahl :ddahl 2013-04-22 17:21:32 PDT
Comment on attachment 739853 [details] [diff] [review]
Patch 1

Review of attachment 739853 [details] [diff] [review]:
-----------------------------------------------------------------

<Just reviewing webconsole.js + tests>

Looks good. How does try server look?
Comment 4 Garrett Robinson [:grobinson] 2013-04-23 09:23:23 PDT
Try run: https://tbpl.mozilla.org/?tree=Try&rev=1a29311aa80f
Comment 5 Garrett Robinson [:grobinson] 2013-04-23 15:17:35 PDT
Try run was green.
Comment 6 Garrett Robinson [:grobinson] 2013-04-23 17:17:50 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f839f4b2f32
Comment 7 Ryan VanderMeulen [:RyanVM] 2013-04-24 05:22:48 PDT
https://hg.mozilla.org/mozilla-central/rev/2f839f4b2f32

Note You need to log in before you can comment on or make changes to this bug.