Closed
Bug 863889
Opened 12 years ago
Closed 12 years ago
nsWindow::Move should compare the same type of pixels when determining if we are moving the window at all
Categories
(Core :: Widget: Win32, defect)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
|
2.42 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #739834 -
Flags: review?(jfkthame)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 739834 [details] [diff] [review]
patch
Review of attachment 739834 [details] [diff] [review]:
-----------------------------------------------------------------
Yup, the check doesn't make sense otherwise! Thanks for catching this.
(I assume there's no visible effect of this fix, as it's just correcting an optimization.)
Attachment #739834 -
Flags: review?(jfkthame) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> (I assume there's no visible effect of this fix, as it's just correcting an
> optimization.)
I didn't notice any bugs, just saw it while reading the code yes. But it's not an optimization we want to do with out: screwing up the similar optimization in nsWindow::Resize caused severe lag in a past bug.
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•