If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsWindow::Move should compare the same type of pixels when determining if we are moving the window at all

RESOLVED FIXED in mozilla23

Status

()

Core
Widget: Win32
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 739834 [details] [diff] [review]
patch
Attachment #739834 - Flags: review?(jfkthame)
Comment on attachment 739834 [details] [diff] [review]
patch

Review of attachment 739834 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, the check doesn't make sense otherwise! Thanks for catching this.

(I assume there's no visible effect of this fix, as it's just correcting an optimization.)
Attachment #739834 - Flags: review?(jfkthame) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> (I assume there's no visible effect of this fix, as it's just correcting an
> optimization.)

I didn't notice any bugs, just saw it while reading the code yes. But it's not an optimization we want to do with out: screwing up the similar optimization in nsWindow::Resize caused severe lag in a past bug.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9d45f30cdc7
https://hg.mozilla.org/mozilla-central/rev/f9d45f30cdc7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.