Closed Bug 863889 Opened 8 years ago Closed 8 years ago

nsWindow::Move should compare the same type of pixels when determining if we are moving the window at all

Categories

(Core :: Widget: Win32, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Attachment #739834 - Flags: review?(jfkthame)
Comment on attachment 739834 [details] [diff] [review]
patch

Review of attachment 739834 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, the check doesn't make sense otherwise! Thanks for catching this.

(I assume there's no visible effect of this fix, as it's just correcting an optimization.)
Attachment #739834 - Flags: review?(jfkthame) → review+
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> (I assume there's no visible effect of this fix, as it's just correcting an
> optimization.)

I didn't notice any bugs, just saw it while reading the code yes. But it's not an optimization we want to do with out: screwing up the similar optimization in nsWindow::Resize caused severe lag in a past bug.
https://hg.mozilla.org/mozilla-central/rev/f9d45f30cdc7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.