Closed Bug 863950 Opened 10 years ago Closed 10 years ago

Crash with outdated CaretPosition object


(Core :: DOM: Core & HTML, defect)

23 Branch
Not set



Tracking Status
firefox22 --- unaffected
firefox23 --- verified


(Reporter: jruderman, Assigned: smaug)



(Keywords: crash, regression, testcase)

Crash Data


(4 files)

Attached file testcase
No description provided.
Attached file stack (gdb)
April 19 Nightly: bp-5bacdafb-ba8f-4059-918d-20fb02130420

April 17 Nightly: did not crash
Keywords: regression
ClientRect getClientRect(); should be  ClientRect? getClientRect();
in our implementation, or we need to change the implementation.
Keywords: regression
Keywords: regression
I don't see getClientRect() in CaretPosition interface in
We should probably also put it on a separate partial interface clearly labeled as Gecko-specific....
Blocks: 803719
Keywords: regression
Attached patch patchSplinter Review
Untested. Will compile tomorrow... well later today.
Attachment #739914 - Flags: review?(bzbarsky)
Comment on attachment 739914 [details] [diff] [review]

Should totally work.  Please land a crashtest too.
Attachment #739914 - Flags: review?(bzbarsky) → review+
Attached patch +testSplinter Review
Assignee: nobody → bugs
On Windows: bp-2bddeb9a-a724-459d-bc2f-55b3b2130420.
Crash Signature: [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, true>::Wrap] → [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, true>::Wrap(JSContext*, JSObject*, nsRefPtr<nsClientRect> const&, JS::Value*) ] [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, int>::Wrap(JSContext*, JSObject*, nsR…
OS: Mac OS X → All
Hardware: x86_64 → All
Version: Trunk → 23 Branch
(In reply to Olli Pettay [:smaug] from comment #10)

Thanks, smaug, for fixing this.
(In reply to Olli Pettay [:smaug] from comment #4)
> I don't see getClientRect() in CaretPosition interface in 

Yeah, I've been trying to get traction on adding it to the spec, but with little success as of yet.
Yeah, thanks bz and smaug.
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Verified as fixed on Firefox 23 beta 3 (also there are no crash reports in Socorro  with the signatures related to this bug).

Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20100101 Firefox/23.0
Build ID: 20130703181823
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.