Crash with outdated CaretPosition object

RESOLVED FIXED in Firefox 23

Status

()

--
critical
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jruderman, Assigned: smaug)

Tracking

(Blocks: 1 bug, {crash, regression, testcase})

23 Branch
mozilla23
crash, regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox22 unaffected, firefox23 verified)

Details

(crash signature)

Attachments

(4 attachments)

(Reporter)

Description

6 years ago
Created attachment 739908 [details]
testcase
(Reporter)

Comment 1

6 years ago
Created attachment 739909 [details]
stack (gdb)
(Reporter)

Comment 2

6 years ago
April 19 Nightly: bp-5bacdafb-ba8f-4059-918d-20fb02130420

April 17 Nightly: did not crash
(Reporter)

Updated

6 years ago
Keywords: regression
ClientRect getClientRect(); should be  ClientRect? getClientRect();
in our implementation, or we need to change the implementation.
Keywords: regression
I don't see getClientRect() in CaretPosition interface in 
http://dev.w3.org/csswg/cssom-view/
We should probably also put it on a separate partial interface clearly labeled as Gecko-specific....
Blocks: 803719
Keywords: regression
tracking-firefox23: --- → ?
Keywords: regression
Created attachment 739914 [details] [diff] [review]
patch

Untested. Will compile tomorrow... well later today.
Attachment #739914 - Flags: review?(bzbarsky)
Comment on attachment 739914 [details] [diff] [review]
patch

Should totally work.  Please land a crashtest too.
Attachment #739914 - Flags: review?(bzbarsky) → review+

Comment 9

6 years ago
On Windows: bp-2bddeb9a-a724-459d-bc2f-55b3b2130420.
Crash Signature: [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, true>::Wrap] → [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, true>::Wrap(JSContext*, JSObject*, nsRefPtr<nsClientRect> const&, JS::Value*) ] [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, int>::Wrap(JSContext*, JSObject*, nsR…
status-firefox22: --- → unaffected
status-firefox23: --- → affected
OS: Mac OS X → All
Hardware: x86_64 → All
Version: Trunk → 23 Branch
(In reply to Olli Pettay [:smaug] from comment #10)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/65ae4b80d835

Thanks, smaug, for fixing this.
(In reply to Olli Pettay [:smaug] from comment #4)
> I don't see getClientRect() in CaretPosition interface in 
> http://dev.w3.org/csswg/cssom-view/

Yeah, I've been trying to get traction on adding it to the spec, but with little success as of yet.
Yeah, thanks bz and smaug.
https://hg.mozilla.org/mozilla-central/rev/65ae4b80d835
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23

Updated

6 years ago
status-firefox23: affected → fixed
tracking-firefox23: ? → ---
Verified as fixed on Firefox 23 beta 3 (also there are no crash reports in Socorro  with the signatures related to this bug).

Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20100101 Firefox/23.0
Build ID: 20130703181823
status-firefox23: fixed → verified
You need to log in before you can comment on or make changes to this bug.