Closed
Bug 863950
Opened 12 years ago
Closed 12 years ago
Crash with outdated CaretPosition object
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
| Tracking | Status | |
|---|---|---|
| firefox22 | --- | unaffected |
| firefox23 | --- | verified |
People
(Reporter: jruderman, Assigned: smaug)
References
Details
(Keywords: crash, regression, testcase)
Crash Data
Attachments
(4 files)
|
313 bytes,
text/html
|
Details | |
|
10.92 KB,
text/plain
|
Details | |
|
554 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
1.42 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•12 years ago
|
||
|
|
Reporter | |
Comment 2•12 years ago
|
||
April 19 Nightly: bp-5bacdafb-ba8f-4059-918d-20fb02130420
April 17 Nightly: did not crash
|
|
Reporter | |
Updated•12 years ago
|
Keywords: regression
|
Assignee | |
Comment 3•12 years ago
|
||
ClientRect getClientRect(); should be ClientRect? getClientRect();
in our implementation, or we need to change the implementation.
Keywords: regression
|
|
Assignee | |
Updated•12 years ago
|
Keywords: regression
|
|
Assignee | |
Comment 4•12 years ago
|
||
I don't see getClientRect() in CaretPosition interface in
http://dev.w3.org/csswg/cssom-view/
|
||
Comment 5•12 years ago
|
||
We should probably also put it on a separate partial interface clearly labeled as Gecko-specific....
Blocks: 803719
Keywords: regression
|
|
||
Updated•12 years ago
|
tracking-firefox23:
--- → ?
Keywords: regression
|
|
Assignee | |
Comment 6•12 years ago
|
||
Untested. Will compile tomorrow... well later today.
Attachment #739914 -
Flags: review?(bzbarsky)
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 739914 [details] [diff] [review]
patch
Should totally work. Please land a crashtest too.
Attachment #739914 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 8•12 years ago
|
||
Assignee: nobody → bugs
|
||
Comment 9•12 years ago
|
||
On Windows: bp-2bddeb9a-a724-459d-bc2f-55b3b2130420.
Crash Signature: [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, true>::Wrap] → [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, true>::Wrap(JSContext*, JSObject*, nsRefPtr<nsClientRect> const&, JS::Value*) ]
[@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<nsClientRect>, int>::Wrap(JSContext*, JSObject*, nsR…
status-firefox22:
--- → unaffected
status-firefox23:
--- → affected
OS: Mac OS X → All
Hardware: x86_64 → All
Version: Trunk → 23 Branch
|
|
Assignee | |
Comment 10•12 years ago
|
||
|
||
Comment 11•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #10)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/65ae4b80d835
Thanks, smaug, for fixing this.
|
|
||
Comment 12•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #4)
> I don't see getClientRect() in CaretPosition interface in
> http://dev.w3.org/csswg/cssom-view/
Yeah, I've been trying to get traction on adding it to the spec, but with little success as of yet.
|
||
Comment 13•12 years ago
|
||
Yeah, thanks bz and smaug.
|
||
Comment 14•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
||
Updated•12 years ago
|
|
||
Updated•12 years ago
|
tracking-firefox23:
? → ---
|
||
Comment 15•12 years ago
|
||
Verified as fixed on Firefox 23 beta 3 (also there are no crash reports in Socorro with the signatures related to this bug).
Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20100101 Firefox/23.0
Build ID: 20130703181823
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•