ContainerLayerOGL tries to bind non-existent buffer

RESOLVED FIXED in mozilla23

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nrc, Assigned: nrc)

Tracking

unspecified
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When we use am intermediate surface for rendering a container layer but don't composite (that is, aManager->CompositingDisabled() is true). We call fBindFramebuffer for an fbo which never got created, which causes us gl grief if we check for gl errors.
(Assignee)

Comment 1

5 years ago
Created attachment 739922 [details] [diff] [review]
fix
Attachment #739922 - Flags: review?(bjacob)
Comment on attachment 739922 [details] [diff] [review]
fix

Review of attachment 739922 [details] [diff] [review]:
-----------------------------------------------------------------

I don't want to be picky as that's an old-layers file IIUC. But I really don't like the design around here. What's this aPreviousFramebuffer argument doing and how do we know that we only have to restore this framebuffer attachment if composition is disabled? Looks fragile.
Attachment #739922 - Flags: review?(bjacob) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b495fe61ee4

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7b495fe61ee4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.