Closed Bug 863968 Opened 8 years ago Closed 8 years ago

ContainerLayerOGL tries to bind non-existent buffer

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: nrc, Assigned: nrc)

Details

Attachments

(1 file)

When we use am intermediate surface for rendering a container layer but don't composite (that is, aManager->CompositingDisabled() is true). We call fBindFramebuffer for an fbo which never got created, which causes us gl grief if we check for gl errors.
Attached patch fixSplinter Review
Attachment #739922 - Flags: review?(bjacob)
Comment on attachment 739922 [details] [diff] [review]
fix

Review of attachment 739922 [details] [diff] [review]:
-----------------------------------------------------------------

I don't want to be picky as that's an old-layers file IIUC. But I really don't like the design around here. What's this aPreviousFramebuffer argument doing and how do we know that we only have to restore this framebuffer attachment if composition is disabled? Looks fragile.
Attachment #739922 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/7b495fe61ee4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.