864026 - CSSLint and JSHint fail on master

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[David Humphrey (:humph)]

dave@hospitality:~/repos/MakeAPI(master)$ npm test

> makeapi@0.0.1 test /Users/dave/Sites/repos/MakeAPI
> grunt

Running "csslint:files" (csslint) task
Linting public/gallery/style/style.css...ERROR
[L22:C3]
Fallback background (hex or RGB) should precede RGBA background. For older browsers that don't support RGBA, HSL, or HSLA, provide a fallback color. (fallback-colors)
Linting public/stylesheets/search.css...ERROR
[L22:C20]
The universal selector (*) is known to be slow. The universal selector (*) is known to be slow. (universal-selector)
Linting public/stylesheets/style.css...ERROR
[L1:C1]
Rule is empty. Rules without any properties specified should be removed. (empty-rules)
Warning: Task "csslint:files" failed. Use --force to continue.

Aborted due to warnings.
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

Comment 1

[David Humphrey (:humph)]

dave@hospitality:~/repos/MakeAPI(master)$ grunt jshint
Running "jshint:files" (jshint) task
Linting server.js...ERROR
[L52:C5] W024: Expected an identifier and instead saw 'delete' (a reserved word).
app.delete( "/api/make/:id", routes.remove );

Linting lib/models/make.js...ERROR
[L14:C3] E024: Unexpected 'default'.
  default: ( new Date() ).getTime(),
[L14:C3] W024: Expected an identifier and instead saw 'default' (a reserved word).
  default: ( new Date() ).getTime(),
[L35:C5] E024: Unexpected 'default'.
    default: "en_us",
[L35:C5] W024: Expected an identifier and instead saw 'default' (a reserved word).
    default: "en_us",
[L36:C21] W070: Extra comma. (it breaks older versions of IE)
    es_indexed: true,
[L41:C19] W070: Extra comma. (it breaks older versions of IE)
    required: true,
[L46:C19] W070: Extra comma. (it breaks older versions of IE)
    required: true,
[L51:C19] W070: Extra comma. (it breaks older versions of IE)
    required: true,
[L79:C5] E024: Unexpected 'default'.
    default: true
[L79:C5] W024: Expected an identifier and instead saw 'default' (a reserved word).
    default: true
[L95:C5] E024: Unexpected 'default'.
    default: null,
[L95:C5] W024: Expected an identifier and instead saw 'default' (a reserved word).
    default: null,

Linting public/js/make-api.js...ERROR
[L5:C1] W097: Use the function form of "use strict".
"use strict";
[L117:C35] W065: Missing radix parameter.
        this.size = parseInt( num ) || DEFAULT_SIZE;
[L132:C20] W033: Missing semicolon.
        return this 
[L50:C23] W117: 'XMLHttpRequest' is not defined.
    var request = new XMLHttpRequest();
[L159:C44] W117: 'escape' is not defined.
        doXHR( "GET", "/api/makes/search", escape( JSON.stringify( searchQuery ) ), callback );
[L182:C13] W117: 'require' is not defined.
  request = require( "request" );
[L185:C45] W117: 'define' is not defined.
} else if ( typeof define === "function" && define.amd ) {
[L187:C3] W117: 'define' is not defined.
  define(function() {
[L192:C3] W117: 'window' is not defined.
  window.Make = Make;

Linting public/js/search.js...ERROR
[L90:C59] W033: Missing semicolon.
    make.update( makeId.value, getData(), handleResponse ) 
[L95:C4] W033: Missing semicolon.
  } 

Linting routes/make.js...ERROR
[L1:C1] W097: Use the function form of "use strict".
"use strict";
[L72:C22] W069: ['s'] is better written in dot notation.
      if ( !req.query[ "s" ] ) {
[L76:C41] W069: ['s'] is better written in dot notation.
      searchData = JSON.parse( req.query[ "s" ] );
[L3:C12] W117: 'require' is not defined.
var Make = require( "../lib/models/make" );
[L5:C1] W117: 'module' is not defined.
module.exports = function() {

Warning: Task "jshint:files" failed. Use --force to continue.

Aborted due to warnings.

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/24

Added .travis.yml and Fixed CSS and JSHint fails.

https://travis-ci.org/mozilla/MakeAPI/builds/6542810

Comment 3

[Chris DeCairos (:cade)]

I totally put this on the wrong bug.

Comment 4

[Chris DeCairos (:cade)]

Comment on attachment 740366 [details] [review]
https://github.com/mozilla/MakeAPI/pull/24

moving to correct bug. (clearing flags.) see Bug 864334

Comment 5

[Chris DeCairos (:cade)]

Fixed by: https://github.com/mozilla/MakeAPI/commit/4bf078c9c2ed36549c4d7694030e23523ff6ceac - which landed in Bug 864334