Closed Bug 864086 Opened 7 years ago Closed 7 years ago

Simplify AudioNode::DestroyMediaStream callers

Categories

(Core :: Web Audio, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
AudioNode's destructor calls DestroyMediaStream (through calling DisconnectFromGraph), so the comment in the header file about each node class having to call that function from its destructor is a lie!
Attachment #740045 - Flags: review?(paul)
Comment on attachment 740045 [details] [diff] [review]
Patch (v1)

Review of attachment 740045 [details] [diff] [review]:
-----------------------------------------------------------------

Careful, there are chunks from the patch for bug 864083 in this patch.
Attachment #740045 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/0b45b14fd0c0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.