864158 - Add support for developers key to package.json

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Same idea as bug 809335 but for the developers key https://developer.mozilla.org/en-US/docs/Install_Manifests#developer

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Maybe we should just adopt NodeJS's 'contributors' style (if not already) and add a 'type' property with 'translator' and 'developer' as optional values.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I'd vote for NodeJS's contributors.

Comment 3

[Giovanny Gongora [:gioyik]]

Hi,

I created a pull request with a fix for this. Could you review it and see if the changes are good?

Regards,
Gio

Comment 4

[Giovanny Gongora [:gioyik]]

Attachment: Patch

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 833398 [details] [review]
Patch

Erik, pass on the review if you can't do it. :)

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 833398 [details] [review]
Patch

This looks alright, it will needs some tests though.  If you'd like some help with this let us know!  I would use a test addon for this bug, you can find some examples here https://github.com/mozilla/addon-sdk/tree/master/test/addons

Also you should know that we are working on removing the pythion code eventually so the less you touch that code the easier it will be to land this.

Comment 7

[Giovanny Gongora [:gioyik]]

Hi Erik,

The part of the test is not totally clear to me. I was seeing bug 809335 and they didn't pull test, so i am not sure about what to do with test. I need to create an example addon as the ones in the addon-sdk example (https://github.com/mozilla/addon-sdk/tree/master/test/addons) implementing the new feature in the Pull Request? that example needs to be in a Pull Request too?

Regards,
Gio

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Giovanny Andres Gongora Granada from comment #7)
> Hi Erik,
> 
> The part of the test is not totally clear to me. I was seeing bug 809335 and
> they didn't pull test, so i am not sure about what to do with test. I need
> to create an example addon as the ones in the addon-sdk example
> (https://github.com/mozilla/addon-sdk/tree/master/test/addons) implementing
> the new feature in the Pull Request? that example needs to be in a Pull
> Request too?
> 
> Regards,
> Gio

Thanks for pointing that out, that should not have happened, but it can..

I made bug 945315 about this issue that you've mentioned, and I'll try to have a patch added in the next day or two which we can basically copy for this bug.

Comment 9

[Erik Vold [:erikvold] (please needinfo? me)]

There is a test example in bug 945315 now, basically just needs a copy and paste and a few lines changed.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/77db1e614a78e117e033d1a83289a3766af010a6
Bug 864158 - Add support for developers key to package.json r=@erikvold

https://github.com/mozilla/addon-sdk/commit/dfb9cabc5b14a1e619d71f3d069914ffe212f22a
Bug 864158 - Add test addon for developers key in package.json a=me

https://github.com/mozilla/addon-sdk/commit/82306bd6d7bb85455654935464a197a086f3446d
Merge pull request #1610 from erikvold/1296

Bug 864158 - Add support for developers key to package.json r=@erikvold

Comment 11

[Erik Vold [:erikvold] (please needinfo? me)]

Thanks!