Closed Bug 864166 Opened 7 years ago Closed 7 years ago

Cleanup nsGlobalWindow some

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(4 files)

No description provided.
Attachment #740104 - Flags: review?(mounir)
Attachment #740102 - Flags: review?(mounir) → review+
Attachment #740103 - Flags: review?(mounir) → review+
Attachment #740104 - Flags: review?(mounir) → review+
Comment on attachment 740105 [details] [diff] [review]
Part d: Outparamdel GetWebBrowserChrome

Review of attachment 740105 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsBarProps.cpp
@@ +93,5 @@
>    nsCOMPtr<nsIDOMWindow> domwin(do_QueryReferent(mDOMWindowWeakref));
>    if (!domwin)
>      return nullptr;
>  
> +  return mDOMWindow->GetWebBrowserChrome();

nit: you could write:
return domwin ? mDOMWindow->GetWebBrowserChrome() : nullptr;
Attachment #740105 - Flags: review?(mounir) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.