864180 - move audio software decoder from mediaserver process to app's process

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #853977 +++

Create this bug from Bug 853977 comment #63.

Bug 803471, all codecs of OMXCodec move to mediaserver process. But this change add IPC overhead. The overhead become significant when a lot of OMXCodecs are loaded.

Only hardware codecs are needed to be loaded in mediaserver process. Software codecs can be loaded in app's process as in Firefox OS v1.0.1

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - move audio software decoder to app's process

Comment 2

[cajbir (:cajbir)]

I thought we weren't using software codecs?

Comment 3

[cajbir (:cajbir)]

(In reply to Chris Double (:doublec) from comment #2)
> I thought we weren't using software codecs?

Oh audio only, I missed that, thanks.

Comment 4

[Sotaro Ikeda [:sotaro]]

Some apps like game uses a lot of audio codecs. It increases IPC messages a lot. It causes delay of audio codecs data handling and causes timeout at the codecs. By loading audio software codecs in application process, IPC message can be reduced.

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 740122 [details] [diff] [review]
patch - move audio software decoder to app's process

doublec, can you review the patch?

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Can we get some more information on the user win here if we take this change?  We'll track and look at an uplift nomination with that info as well as a risk assessment, but this is not a blocker based on the lack of data on how this will benefit the user/product.

Comment 7

[Sotaro Ikeda [:sotaro]]

user win is speed up of start up time codec load. This come to speed up of "app Poppit" start.

Comment 8

[Sotaro Ikeda [:sotaro]]

doublec, review ping.

Comment 9

[Sotaro Ikeda [:sotaro]]

nominated to leo again.
Without the change, an app that loads a lot of mp3 files failed to load some mp3 files during app's start up because of timeout and then failed to start up the app, like 3rd party app Poppit in Bug 853977 comment #14.
And the change reduces Binder IPC messages, it could speed up apps' start up performance that uses a lot of mp3 files.

Comment 10

[Sotaro Ikeda [:sotaro]]

By applying attachment 740122 [details] [diff] [review], 3rd party app Poppit can start up normally on MozBuild Leo . Before the patch, the app failed to start up because of mp3 file load timeout.

Comment 11

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=e79fc7c89b00

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - move audio software decoder to app's process

Committable patch. Carry "chris.double: review+"

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/658705597992

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/658705597992

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/b12f63fa6dc7