Closed
Bug 864180
Opened 11 years ago
Closed 11 years ago
move audio software decoder from mediaserver process to app's process
Categories
(Core :: Audio/Video, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox21 | --- | wontfix |
firefox22 | --- | wontfix |
firefox23 | --- | fixed |
b2g18 | + | fixed |
b2g18-v1.0.0 | --- | unaffected |
b2g18-v1.0.1 | --- | unaffected |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
(Keywords: perf, regression, Whiteboard: [c= p=3])
Attachments
(1 file, 1 obsolete file)
2.83 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #853977 +++
Create this bug from Bug 853977 comment #63.
Bug 803471, all codecs of OMXCodec move to mediaserver process. But this change add IPC overhead. The overhead become significant when a lot of OMXCodecs are loaded.
Only hardware codecs are needed to be loaded in mediaserver process. Software codecs can be loaded in app's process as in Firefox OS v1.0.1
Assignee | ||
Updated•11 years ago
|
blocking-b2g: leo+ → leo?
Assignee | ||
Updated•11 years ago
|
Summary: move mp3 software codec from mediasercver process to app's process → move audio software decoder from mediasercver process to app's process
Assignee | ||
Updated•11 years ago
|
Summary: move audio software decoder from mediasercver process to app's process → move audio software decoder from mediaserver process to app's process
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → sotaro.ikeda.g
Comment 2•11 years ago
|
||
I thought we weren't using software codecs?
Comment 3•11 years ago
|
||
(In reply to Chris Double (:doublec) from comment #2)
> I thought we weren't using software codecs?
Oh audio only, I missed that, thanks.
Assignee | ||
Comment 4•11 years ago
|
||
Some apps like game uses a lot of audio codecs. It increases IPC messages a lot. It causes delay of audio codecs data handling and causes timeout at the codecs. By loading audio software codecs in application process, IPC message can be reduced.
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 740122 [details] [diff] [review]
patch - move audio software decoder to app's process
doublec, can you review the patch?
Attachment #740122 -
Flags: review?(chris.double)
Comment 6•11 years ago
|
||
Can we get some more information on the user win here if we take this change? We'll track and look at an uplift nomination with that info as well as a risk assessment, but this is not a blocker based on the lack of data on how this will benefit the user/product.
blocking-b2g: leo? → -
tracking-b2g18:
--- → +
Assignee | ||
Comment 7•11 years ago
|
||
user win is speed up of start up time codec load. This come to speed up of "app Poppit" start.
Assignee | ||
Comment 8•11 years ago
|
||
doublec, review ping.
Assignee | ||
Updated•11 years ago
|
Whiteboard: c=performance p=4
Updated•11 years ago
|
Status: NEW → ASSIGNED
Updated•11 years ago
|
Attachment #740122 -
Flags: review?(chris.double) → review+
Assignee | ||
Comment 9•11 years ago
|
||
nominated to leo again.
Without the change, an app that loads a lot of mp3 files failed to load some mp3 files during app's start up because of timeout and then failed to start up the app, like 3rd party app Poppit in Bug 853977 comment #14.
And the change reduces Binder IPC messages, it could speed up apps' start up performance that uses a lot of mp3 files.
blocking-b2g: - → leo?
Assignee | ||
Comment 10•11 years ago
|
||
By applying attachment 740122 [details] [diff] [review], 3rd party app Poppit can start up normally on MozBuild Leo . Before the patch, the app failed to start up because of mp3 file load timeout.
Updated•11 years ago
|
blocking-b2g: leo? → leo+
Keywords: regression
Updated•11 years ago
|
Whiteboard: c=performance p=4 → c=audio p=4
Assignee | ||
Comment 11•11 years ago
|
||
Assignee | ||
Comment 12•11 years ago
|
||
Committable patch. Carry "chris.double: review+"
Attachment #740122 -
Attachment is obsolete: true
Attachment #745718 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 13•11 years ago
|
||
Keywords: checkin-needed
Comment 14•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Comment 15•11 years ago
|
||
status-b2g18-v1.0.0:
--- → unaffected
status-firefox21:
--- → wontfix
status-firefox22:
--- → wontfix
status-firefox23:
--- → fixed
Updated•11 years ago
|
Flags: in-moztrap-
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•