864190 - Function should throw exception instead of returning null

Status: RESOLVED WONTFIX

(Calendar :: Internal Components, defect)

Description

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

At https://mxr.mozilla.org/comm-central/source/calendar/base/modules/calProviderUtils.jsm#133 the function should throw the catched exception instead of later returning null. Components.returnCode seems to be more or less deprecated.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 740128 [details] [diff] [review]
Patch v1

I don't know if this has changed, but back when this was written the network code displayed ugly messages and I think also bailed out if the exception is thrown here. Did you verify that?

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 740128 [details] [diff] [review]
Patch v1

r- per previous comment. Please either give me proof it is the way to go now or WONTFIX :)

Comment 3

[Martin Schröder [:mschroeder]]

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Comment on attachment 740128 [details] [diff] [review]
> Patch v1
> 
> r- per previous comment. Please either give me proof it is the way to go now
> or WONTFIX :)

Okay, will try to verify that... when I get my build working again.

Comment 4

[Martin Schröder [:mschroeder]]

Resolving as WONTFIX per comment#2.