Last Comment Bug 864192 - Move EXPORTS to moz.build in comm-central
: Move EXPORTS to moz.build in comm-central
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: Thunderbird 23.0
Assigned To: Joshua Cranmer [:jcranmer]
:
Mentors:
Depends on: 846634
Blocks: 864191
  Show dependency treegraph
 
Reported: 2013-04-21 15:42 PDT by Joshua Cranmer [:jcranmer]
Modified: 2013-05-09 10:16 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Move exports to moz.build (39.25 KB, patch)
2013-05-07 10:39 PDT, Joshua Cranmer [:jcranmer]
no flags Details | Diff | Splinter Review
Kill newly-dead makefiles (6.01 KB, patch)
2013-05-07 10:39 PDT, Joshua Cranmer [:jcranmer]
standard8: review+
Details | Diff | Splinter Review
Move exports to moz.build (24.03 KB, patch)
2013-05-07 10:40 PDT, Joshua Cranmer [:jcranmer]
standard8: review+
Details | Diff | Splinter Review

Description Joshua Cranmer [:jcranmer] 2013-04-21 15:42:16 PDT

    
Comment 1 Joshua Cranmer [:jcranmer] 2013-05-07 10:39:14 PDT
Created attachment 746507 [details] [diff] [review]
Move exports to moz.build

90% automated movement.
Comment 2 Joshua Cranmer [:jcranmer] 2013-05-07 10:39:54 PDT
Created attachment 746508 [details] [diff] [review]
Kill newly-dead makefiles
Comment 3 Joshua Cranmer [:jcranmer] 2013-05-07 10:40:39 PDT
Created attachment 746510 [details] [diff] [review]
Move exports to moz.build

Uploading the right version would help.
Comment 4 Mark Banner (:standard8) (afk until 26th July) 2013-05-08 01:37:37 PDT
Comment on attachment 746510 [details] [diff] [review]
Move exports to moz.build

Review of attachment 746510 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/util/moz.build
@@ +25,5 @@
> +]
> +
> +EXPORTS.mozilla.mailnews += [
> +    'Services.h',
> +    'ServiceList.h',

ServiceList.h before Services.h please

Note You need to log in before you can comment on or make changes to this bug.