Move EXPORTS to moz.build in comm-central

RESOLVED FIXED in Thunderbird 23.0

Status

MailNews Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jcranmer, Assigned: jcranmer)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 23.0
x86_64
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 746507 [details] [diff] [review]
Move exports to moz.build

90% automated movement.
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #746507 - Flags: review?(mbanner)
(Assignee)

Comment 2

4 years ago
Created attachment 746508 [details] [diff] [review]
Kill newly-dead makefiles
Attachment #746508 - Flags: review?(mbanner)
(Assignee)

Comment 3

4 years ago
Created attachment 746510 [details] [diff] [review]
Move exports to moz.build

Uploading the right version would help.
Attachment #746507 - Attachment is obsolete: true
Attachment #746507 - Flags: review?(mbanner)
Attachment #746510 - Flags: review?(mbanner)
Comment on attachment 746510 [details] [diff] [review]
Move exports to moz.build

Review of attachment 746510 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/util/moz.build
@@ +25,5 @@
> +]
> +
> +EXPORTS.mozilla.mailnews += [
> +    'Services.h',
> +    'ServiceList.h',

ServiceList.h before Services.h please
Attachment #746510 - Flags: review?(mbanner) → review+
Attachment #746508 - Flags: review?(mbanner) → review+

Updated

4 years ago
Depends on: 870401

Updated

4 years ago
No longer depends on: 870401
(Assignee)

Comment 5

4 years ago
Pushed:
https://hg.mozilla.org/comm-central/rev/7c1152537563
https://hg.mozilla.org/comm-central/rev/004899f9fceb
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.