Put the baseline memory reports in a tree.

RESOLVED FIXED in mozilla23

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The per-compartment Baseline memory reports aren't grouped into a sub-tree,
viz:

│   ├─────429,568 B (00.25%) ── baseline-fallback-stubs
│   ├─────285,696 B (00.17%) ── compartment-object
│   ├─────154,288 B (00.09%) ── baseline-data
│   ├─────147,456 B (00.09%) ── baseline-optimized-stubs

They should be.
(Assignee)

Comment 1

5 years ago
Created attachment 740144 [details] [diff] [review]
Put the baseline memory reports in a tree.

This patch groups them like so:

│  ├──────97,856 B (00.32%) -- baseline
│  │      ├──77,312 B (00.25%) -- stubs
│  │      │  ├──56,832 B (00.19%) ── fallback
│  │      │  └──20,480 B (00.07%) ── optimized
│  │      └──20,544 B (00.07%) ── data

It also tweaks a couple of the descriptions to follow the "the X compiler"
phrase used in other descriptions.
Attachment #740144 - Flags: review?(jdemooij)
Comment on attachment 740144 [details] [diff] [review]
Put the baseline memory reports in a tree.

Review of attachment 740144 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #740144 - Flags: review?(jdemooij) → review+

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/cfa76f87cb15
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.